Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Jun 2015 10:27:47 +0800
From:      Kevin Lo <kevlo@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>
Cc:        Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>, current@FreeBSD.org, adrian@FreeBSD.org
Subject:   Re: converted ral(4) Was: [Testers needed!] WiFi drivers changes
Message-ID:  <20150608022747.GA86562@ns.kevlo.org>
In-Reply-To: <20150605031606.GA47851@ns.kevlo.org>
References:  <20150529133535.GT73119@glebius.int.ru> <20150604111808.GG73119@glebius.int.ru> <20150605031606.GA47851@ns.kevlo.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 05, 2015 at 11:16:06AM +0800, Kevin Lo wrote:
> 
> On Thu, Jun 04, 2015 at 02:18:08PM +0300, Gleb Smirnoff wrote:
> > 
> >   Hi Kevin and Olivier,
> 
> Hi Gleb,
> 
> > 
> >   you signed up as testers of ral(4). I have converted ral(4)
> > and uploaded new patch at:
> > 
> > https://reviews.freebsd.org/D2655
> > 
> > Please try, report and update the project page.
> > 
> > https://wiki.freebsd.org/projects/ifnet/net80211
> > 
> > Thanks a lot for your help.
> 
> It works fine for me.  Tested on RT5390, thanks.

As I mentioned in a private message, the diff below changes ifp->if_drv_flags
to sc->sc_flags, thanks.

--- D2655.diff.orig	2015-06-08 10:20:12.220844488 +0800
+++ D2655.diff	2015-06-08 10:20:38.020180596 +0800
@@ -6279,7 +6279,7 @@
  	RAL_LOCK_ASSERT(sc);
  
 -	KASSERT(ifp->if_drv_flags & IFF_DRV_RUNNING, ("not running"));
-+	KASSERT(ifp->if_drv_flags & RAL_RUNNING, ("not running"));
++	KASSERT(sc->sc_flags & RAL_RUNNING, ("not running"));
  
  	if (sc->sc_invalid)		/* card ejected */
  		return;
@@ -7109,7 +7109,7 @@
  	RAL_LOCK_ASSERT(sc);
  
 -	KASSERT(ifp->if_drv_flags & IFF_DRV_RUNNING, ("not running"));
-+	KASSERT(ifp->if_drv_flags & RT2860_RUNNNING, ("not running"));
++	KASSERT(sc->sc_flags & RT2860_RUNNNING, ("not running"));
  
  	if (sc->sc_invalid)		/* card ejected */
  		return;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150608022747.GA86562>