From owner-freebsd-scsi@FreeBSD.ORG Fri Aug 23 23:32:17 2013 Return-Path: Delivered-To: scsi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 41C4E507 for ; Fri, 23 Aug 2013 23:32:17 +0000 (UTC) (envelope-from will@firepipe.net) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 048C02C0C for ; Fri, 23 Aug 2013 23:32:16 +0000 (UTC) Received: by mail-ve0-f169.google.com with SMTP id db10so915310veb.0 for ; Fri, 23 Aug 2013 16:32:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:mime-version:date:message-id:subject:from:to :content-type; bh=BF3J+o9ZSdGyri8i9n4Gl2jkv41kJZCcnK2iXHksKGc=; b=c2llrjALGuAs2s/3e999P4/5CCkD8uuBQZJnGWzRAF4WxGpdFB6Lf7UIw8z/GaMe/s bGCYr9LOZcWvDDyleIoXPcQo4Xg6MjharTBzgUyMHsWD7QJ3Y3EkE+ElxMo81DhD/NT2 BWkaXwZoQ9RGwa+lsCOYNJrbH1cj7gY7rIDZWjlq9YMVbHChIOH67wWdcVM4qVh579jv AwiEWkfgjz0waMIUDNMr6cJ8KOSPzYIeIX0WN2ioVhTSk7LMm2tLDKVYICsyF0BFc46M S9wj+REFyXzOIme1kTnTk+JMWOfwbqwwiQajFXC70EDwuUB5BqJF0ecd0phM0T8Nd5JX AHZQ== X-Gm-Message-State: ALoCoQlQf6XgDzJ3OCRlSJrK0cYKhOW5N1+rsdBAlCxVYywfPvWRivaUPhr2m6J/2VR4L83ul2ff MIME-Version: 1.0 X-Received: by 10.58.196.132 with SMTP id im4mr105872vec.28.1377300730150; Fri, 23 Aug 2013 16:32:10 -0700 (PDT) Received: by 10.58.226.66 with HTTP; Fri, 23 Aug 2013 16:32:10 -0700 (PDT) Date: Fri, 23 Aug 2013 17:32:10 -0600 Message-ID: Subject: 8K quirks & making quirk table more structured From: Will Andrews To: scsi@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2013 23:32:17 -0000 Hi, We have seen 8K blocksize devices in our lab, which require quirks to behave properly. Rather than simply add another quirk for a different size, we made the quirk entries more structured, and changed blocksize to be a fixed-size integer element. Please review: http://people.freebsd.org/~will/head-convert-cam-quirk-tables-to-structs.diff The naming isn't particularly intuitive, but I'd like to check this in as primarily a structural change, and follow up with other improvements later. Thanks! --Will.