From owner-freebsd-current Mon Oct 22 5:58:11 2001 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 6401A37B403 for ; Mon, 22 Oct 2001 05:58:08 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id WAA16389; Mon, 22 Oct 2001 22:58:03 +1000 Date: Mon, 22 Oct 2001 22:57:09 +1000 (EST) From: Bruce Evans X-X-Sender: To: Harry Starr Cc: current Subject: Re: Current makeworld seems broken. In-Reply-To: <007901c15a9b$f1495430$0a9811cb@gccs.com.au> Message-ID: <20011022224252.M55633-100000@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 22 Oct 2001, Harry Starr wrote: > The problem is the new inclusion of ipfilter stuff. > > Make will change directory to .OBJDIR if it exists, and it does NOW that > there is an ipfilter SUBDIR. The support for a separate object tree unfortunately gives separate object directories even to places like src/share/examples/ that don't need object directories (and explicitly unrequest them by setting NOOBJ). The ipfilter stuff doesn't need an object directory, but is too broken to set NOOBJ. This shoots its parent in the foot by causing the creation of the parent of its object directory (this directory becomes the parent's object directory). This is easy to fix by setting NOOBJ correctly, but in general a subdir of src/share/examples/ might actually need an object directory, and then something like your fix is needed. Another problem with all this is that the ipfilter subdir is only added in the (default) SHARED=copies case, so the object directories only get created in this case. This causes problems switching SHARED. E.g., "SHARED=symlinks make cleandir" doesn't clean the object directories that may have been created by a previous "SHARED=copies make". This is easy to fix by setting NOOBJ correctly. There would only be a problem in the not so general case where a conditionally built subdir needs an object directory. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message