From owner-freebsd-current@FreeBSD.ORG Thu Mar 26 14:59:30 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C3C1A52 for ; Thu, 26 Mar 2015 14:59:30 +0000 (UTC) Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1]) by mx1.freebsd.org (Postfix) with ESMTP id 965115F2 for ; Thu, 26 Mar 2015 14:59:29 +0000 (UTC) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id B136527047C5 for ; Thu, 26 Mar 2015 15:59:26 +0100 (CET) Received: from localhost (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 478D82704F4A for ; Thu, 26 Mar 2015 15:59:26 +0100 (CET) Received: from work.netasq.com ([127.0.0.1]) by localhost (work.netasq.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mcMRD9kGRhhU for ; Thu, 26 Mar 2015 15:59:26 +0100 (CET) Received: from pc-alex.localnet (unknown [10.2.200.254]) by work.netasq.com (Postfix) with ESMTP id D57A627047C5 for ; Thu, 26 Mar 2015 15:59:25 +0100 (CET) From: Alexandre Martins To: freebsd-current@freebsd.org Subject: Mbuf leak in if_lagg.c Date: Thu, 19 Mar 2015 17:31:18 +0100 Message-ID: <1708955.mQ2X6OUmTD@pc-alex> Organization: NETASQ User-Agent: KMail/4.14.2 (FreeBSD/10.0-RELEASE-p12; KDE/4.14.2; amd64; ; ) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2478880.Cgndx6u02g"; micalg="sha1"; protocol="application/pkcs7-signature" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2015 14:59:30 -0000 --nextPart2478880.Cgndx6u02g Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Hi ! I found a leak of mbuf in the lagg driver : https://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?view=3Dannotate#= l1672 =2D=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- m =3D (lp->lp_detaching =3D=3D 0) ? lagg_proto_input(sc, lp, m) : NULL;= =2D=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- If lp_detaching is non 0, the mbuf pointer is set to NULL without m_fre= em it. Can you look at this ? Regards =2D-=20 Alexandre Martins STORMSHIELD --nextPart2478880.Cgndx6u02g Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Disposition: attachment; filename="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIIhDCCBIYw ggJuoAMCAQICBQDbzPDtMA0GCSqGSIb3DQEBCwUAMEgxCzAJBgNVBAYTAkZSMRQwEgYDVQQKDAtT VE9STVNISUVMRDEjMCEGA1UEAwwaU3Rvcm1zaGllbGQgUm9vdCBBdXRob3JpdHkwHhcNMTQwOTA0 MTUwNzEwWhcNMjQwOTAxMTUwNzEwWjBJMQswCQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElF TEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVzZXJzIEF1dGhvcml0eTCCASIwDQYJKoZIhvcNAQEB BQADggEPADCCAQoCggEBAMKHBaAL/pVYovuOBYjd4DaxW9F07C4dxexEABdVZ2UwLTKCDu7jkTvw aECel2XxBsi7vH9DbM6roq22ynAMQiOSgwtNmeAsuUaNglk9+5KgLqGX1Hu9F3l/wWG7e/TFD/u/ MpjPgLzfogYKuTfWCas87QfR/GTLEIx+GhNPO57ehdbUiyZDAKs4867ZjzZAA0OFuJ9YuMhYl62e PnxhEpHzYoGzcWVurG2nSaL34izAy8IJFKhP45EHvcKXpRG3tCbsFwP6qeQn27CVQL3h0iVPaFfj Jtj/D+ywDXsTDjXx+DJEJZBfOCNmBn9dRzDZY/10iCADs+D5z/F5E4kfXO8CAwEAAaN2MHQwHQYD VR0OBBYEFKFthGyigIUFfHx1dYA0wRNbl9eBMB8GA1UdIwQYMBaAFLhCqfpnRPB/02GM7KXHUK60 veyjMA8GA1UdEwEB/wQFMAMBAf8wDgYDVR0PAQH/BAQDAgEGMBEGCWCGSAGG+EIBAQQEAwIBBjAN BgkqhkiG9w0BAQsFAAOCAgEAToL3OS3Ynp0+bYotvNFLqsEhhk0WLRfn2Dd6RDZJzhRayr4Hcvzq PnGdBJGcgz8MpXX5DZQdtT+qyHhy2jZ/BNXpX5onTtW79skTWsA3gAjhXbrK1/tWgFwGNVkmrykc 4yn8bZ5AfsXXGrOaXrwOkqS7rppRqWRwL0gzzabsBbdgDK8OhgQByG/irIvyqFUsunos2u7xk6Ew QuFktaXi6XD9IUMyFwFLojjALqJyPvUwsZKuvrW8yS0x3BD4IYVDnPkltrEzrVWDMprLz6CXD7FN umeK2sN+GTMezZ93A466ve+02c2yt0FaJg+x4naThUYPui/mQhNBlySZnIX9X4iv/9qAlAZW7CEN kJeBc6+uN74Utinu1D2mBK8tuW6HUD7LB/IecUjifq1nL1IPcwgOBZHgrAUszVCa3c1Bvfa2Sr1W bSNRxBcV9udYosD2SvDebw2YKqEvk/Ol856Bg5zRAlZ8xBqbF5bFcwuTq4qKxL//5Wp+kJrknHne 370Oag3X6hviM6ms9pfq18EGvl2NqHbLM8aMcQHnZWBZfEgX2UIzbPtDD7MVvY8h015KMiQ0QWD/ WisoABrmBBcBDKc3YnsT5ot/ZcuEdxLS/73KiKw8TD35NvkXW5CH6DNgPklRRhxhadydfyA/yTpf 4XmZD/zUig0v8h6PEmDL8ugwggP2MIIC3qADAgECAgUAhSjIwzANBgkqhkiG9w0BAQUFADBJMQsw CQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElFTEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVz ZXJzIEF1dGhvcml0eTAeFw0xNDA5MDQxNTEwMzhaFw0xNTA5MDQxNTEwMzhaMHAxCzAJBgNVBAYT AkZSMRQwEgYDVQQKDAtTVE9STVNISUVMRDEaMBgGA1UEAwwRQWxleGFuZHJlIE1BUlRJTlMxLzAt BgkqhkiG9w0BCQEWIGFsZXhhbmRyZS5tYXJ0aW5zQHN0b3Jtc2hpZWxkLmV1MIIBIjANBgkqhkiG 9w0BAQEFAAOCAQ8AMIIBCgKCAQEAva7AtO0nbBUoYsRPeAP+85Lv4zx5bPdpxLuQVJmFJL6VDH28 Qxoxlq0j/3HGdfFR2sFe+utPledu6F79SCJDYRQ5ZQuS+TFgyvVzCSuVqpw6z0LQdTh4pouCh71B Bb8RSUXX2zx7Fu5IlSpLjGIf0prk1xrz/YyHJLQo2mSusnogi6hF2GsEVViUZtemK+uPqVToJ5oR AAJ4mU/Xl3aCOd7O3UzNT3T0clrfpNHKrcWcyqgE6g/gY/7NiJESRov3De8xzcczLxJFO51ODlaw y8yT1AHyWIDEkcbgX1Gk4s1ImXQDoq6pQEq2O5cIr59GlSd/YBq36Av6J3LGcmVnQwIDAQABo4G9 MIG6MB0GA1UdDgQWBBTL/0iutSuRsFLRxja4yiLlnMg2rTAfBgNVHSMEGDAWgBShbYRsooCFBXx8 dXWANMETW5fXgTAJBgNVHRMEAjAAMA4GA1UdDwEB/wQEAwID6DArBgNVHREEJDAigSBhbGV4YW5k cmUubWFydGluc0BzdG9ybXNoaWVsZC5ldTARBglghkgBhvhCAQEEBAMCBLAwHQYDVR0lBBYwFAYI KwYBBQUHAwQGCCsGAQUFBwMCMA0GCSqGSIb3DQEBBQUAA4IBAQBHvjAZNyBp1pfsgV5R2oECDTsU vzfyvrj1CVTbOCXtg036DS7Tms7oybwsxUv6kQg9iq5eAklfyuz53VkL9IArm/iWn9QwecxANeMq k3Lc1LIMPhqqg6WZDze1G2PfYlwBkputKyQlhifQ8Xx6wJ+avt1lum5P1EFcQfG6zreyOxfai99a QcAxP1Ry3nXQMbUzP5UZkK0+PhYvy9mTv4b1vPWxeUMMXSO1TPXN1IkuPzzvR86MDHFO17l/aqJV Mr6Ea2A/deI7JilI48fb8jTsAaxBWL5RwrreXLXBjKDsEYzrANB4Kn/uQzkjnRM1NVRS+SMro3tk hzfdSmUFXs5tMYICAzCCAf8CAQEwUjBJMQswCQYDVQQGEwJGUjEUMBIGA1UECgwLU1RPUk1TSElF TEQxJDAiBgNVBAMMG1N0b3Jtc2hpZWxkIFVzZXJzIEF1dGhvcml0eQIFAIUoyMMwCQYFKw4DAhoF AKCBhzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xNTAzMTkxNjMx MThaMCMGCSqGSIb3DQEJBDEWBBThjeagE2ZiEw0PYUOrJEgvsAGg1jAoBgkqhkiG9w0BCQ8xGzAZ MAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzANBgkqhkiG9w0BAQEFAASCAQACy4NcjQO3y5WP1Z0v Sr5o3mT43+Cvr9vok/ExOZ2rrdtV6b/oUv0sGzALWlCQCK5yLK/KtWyN9a9pCJ2tVVjWjfM/7O3w nDSaQwjHT64x6yn/OjB/w97seYw3GlhTz49OWIivz/zpuezBHpZMGPVxN6o7vbY29hpBCEq0i4M6 VFUzmmELv6O0CL3YZRn5zZXZC1MJRTYFezwEA8pnziUguUBX1ZoF5WzqbLL+ym2RHMZJe4lZdKpg 1n624+dSa9/+obymCwGBhtahsZz4nZoCRRfTyTRIgQpFNJLXp1YgPK1F0Vqc+Etg9QGRpyZQbP1f QKmKNqdBJyHg0lAW2LiHAAAAAAAA --nextPart2478880.Cgndx6u02g--