Date: Mon, 29 Oct 2001 00:12:23 -0800 From: Luigi Rizzo <rizzo@aciri.org> To: "Andrew R. Reiter" <arr@watson.org> Cc: Josef Karthauser <joe@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: ipfw.c -- (was: cvs commit: src/sys/netinet ip_fw.h) Message-ID: <20011029001222.A96017@iguana.aciri.org> In-Reply-To: <Pine.NEB.3.96L.1011029030858.35121B-100000@fledge.watson.org> References: <20011029000216.A95875@iguana.aciri.org> <Pine.NEB.3.96L.1011029030858.35121B-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 29, 2001 at 03:10:06AM -0500, Andrew R. Reiter wrote: > On Mon, 29 Oct 2001, Luigi Rizzo wrote: > : > :I think this is exactly the case where it makes a lot of sense to > :declare vars locally to the block: the start of the function is > :far away, there is a bunch of small conditionals where each > :of them needs to use some temporary variable and those variables > :are meant to be used only within the block. > : > > Yes, but nevertheless, style.9 states it should be so. So unless there is > a move to change style.9, it's pretty much the answer, no? no :) Of course it is subject to interpretation, bue mine is, as i said, > Well, I think that in the above section of style(9), > the only reasonable interpretation of "the routine" is > "the function in which the block is contained"; otherwise, you > should assume that you are not supposed to use local variables > in small functions! (and btw, i am surely responsible of one of the sections of code that you mentioned as an example). cheers luigi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011029001222.A96017>