From owner-freebsd-hackers Sun Nov 12 13:51:01 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id NAA29166 for hackers-outgoing; Sun, 12 Nov 1995 13:51:01 -0800 Received: from rah.star-gate.com (rah.star-gate.com [204.188.121.18]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id NAA28900 for ; Sun, 12 Nov 1995 13:50:36 -0800 Received: from rah.star-gate.com (localhost [127.0.0.1]) by rah.star-gate.com (8.6.12/8.6.9) with ESMTP id NAA03928; Sun, 12 Nov 1995 13:43:15 -0800 Message-Id: <199511122143.NAA03928@rah.star-gate.com> X-Mailer: exmh version 1.6.2 7/18/95 To: Bakul Shah cc: hackers@freebsd.org Subject: Re: linux's lseek vs freebsd's lseek In-reply-to: Your message of "Sun, 12 Nov 1995 13:06:36 PST." <199511122106.NAA21837@netcom22.netcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 12 Nov 1995 13:43:13 -0800 From: "Amancio Hasty Jr." Sender: owner-hackers@freebsd.org Precedence: bulk Hi, I will have to investigate further more since without this change doom and the music server do not work. Tnks, Amancio >>> Bakul Shah said: > > (int)fp->f_offset += (int)uap->offset; > > ^^^^ ^^^^ > > The question is what is the implication of doing a signed addition as > > supposed to an unsigned addition as it is in the original file. > > Huh? f_offset & uap->offset are of type quad_t, which is a > signed quantity and -ve offsets are perfectly reasonable > when you seek relative to file-end or current-position. >