From owner-freebsd-current@freebsd.org  Fri Oct 23 02:02:34 2020
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6DB48438AB0
 for <freebsd-current@mailman.nyi.freebsd.org>;
 Fri, 23 Oct 2020 02:02:34 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4CHSDB2Hnfz4kKL
 for <freebsd-current@freebsd.org>; Fri, 23 Oct 2020 02:02:34 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 3CC9A10E4B; Fri, 23 Oct 2020 02:02:34 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: freebsd-current@freebsd.org
Subject: uefi(8) fails to boot from ZFS with compression=zstd
Date: Fri, 23 Oct 2020 04:02:31 +0200
Message-ID: <o8kt-wvgo-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
 s=dkim; t=1603418554;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type;
 bh=jvFgw/K8KtH3QlxCGJ8A8CnvyVHkjG7kVaR8FsNsstU=;
 b=q8OhJQ9Juoxu+zFvqJoi6E3+yNhJC3aU2CIsJ2RKp0flb04vt+h5HIrRRcI8jp84kh2AxG
 ZtMbG0RaQSMuxD6/0W1StwU2r4E10Z7a2sUotyKUHTrQUP2IFAiN/eVWQg/2TyK7u/J5wn
 vN2pXDJbzj60/OqYYl3oGE7Vqx52dhV4s8NBRR1IAIEuia5Jum6grZHEqlS02msEilOYIL
 bln0rfMWua+fXREwokbYlB12BF1z1P0Wqi/VqDoHyz0yst8o2sKoR60GWXN52ukPVGOSfB
 rGu3o0zu2g2PLsZEYZBh0a8C+eP7aAI6wES/+I4NBjHdY5PTZOo5nI5QNUYvQw==
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1603418554; a=rsa-sha256; cv=none;
 b=qwyF17x+SchAoe/0UqqKiPd+dpZSJ41nJTWC9DL+UEvJKzcjRoH/vs3sHugr+hrLYmO9Ke
 sEJm0sft5yrswRaSt7oXBK1u8qrPzOX1/QZAywkd4RY6AWCgJUCzc23ykvowzPamuRu72w
 mbV6FHpC8AxGbDCUGU2jqGo8LwwPy9h5178j4O+Cnktiev774g3zCr5ljrPKf0vl9BRPDe
 +fYtTUOiEZY9IHiPb5X8Fz2RC40tOYylEdY8YK4ZvtbS/0XhNqlKAyjn3jqvqHTcb5WdNZ
 WD/+Ua3u86b9e7OBX5GbBCjckooCZzsG8BShipjBikcJQy2HBC80cNJ2TF80NA==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Oct 2020 02:02:34 -0000

After r366657 (currently, on r366953) I've tried to boot from a
compression=zstd dataset but it failed to reach loader(8), see below.
However, switching to CSM path (boot1.efi -> gptzfsboot) makes it work.

Am I missing something?

$ strings /boot/boot1.efi | fgrep zstd
org.freebsd:zstd_compress

$ strings /boot/gptzfsboot | fgrep zstd
zstd
/usr/src/sys/contrib/openzfs/module/zstd/zfs_zstd.c
org.freebsd:zstd_compress

$ zpool set bootfs=tank/ROOT/freebsd-zstd tank
$ sh /usr/share/examples/bhyve/vmrun.sh -ATE -d /dev/nda0 -d /dev/nda1 host-freebsd
Launching virtual machine "host-freebsd" ...
fbuf frame buffer base: 0x827800000 [sz 16777216]

>> FreeBSD EFI boot block
   Loader path: /boot/loader.efi

   Initializing modules: ZFS UFS
   Load Path: \EFI\BOOT\BOOTX64.EFI
   Load Device: PciRoot(0x0)/Pci(0x3,0x0)/Sata(0x0,0x0,0x0)/HD(2,GPT,<REDACTED>,0x250,0x5B0)
   BootCurrent: 0000
   BootOrder: 0000[*] 0001 0002 0003
   Probing 8 block devices...not supported
not supported
not supported
better
not supported
not supported
not supported
good
 done
    ZFS found the following pools: tank
    UFS found no partitions
ZFS: unsupported compression algorithm (null)
ZFS: i/o error - all block copies unavailable
Failed to read node from tank (5)
ZFS: unsupported compression algorithm (null)
ZFS: i/o error - all block copies unavailable
Failed to read node from tank (5)
Failed to load '/boot/loader.efi'
panic: No bootable partitions found!
Boot Failed. EFI Hard Drive
...