From owner-freebsd-fs Fri Feb 27 07:57:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id HAA08031 for freebsd-fs-outgoing; Fri, 27 Feb 1998 07:57:16 -0800 (PST) (envelope-from owner-freebsd-fs@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.119.24.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id HAA07993 for ; Fri, 27 Feb 1998 07:57:05 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [194.198.43.36]) by ns1.yes.no (8.8.7/8.8.7) with ESMTP id PAA01659 for ; Fri, 27 Feb 1998 15:56:59 GMT Received: (from eivind@localhost) by bitbox.follo.net (8.8.6/8.8.6) id QAA00456; Fri, 27 Feb 1998 16:56:38 +0100 (MET) Message-ID: <19980227165638.57458@follo.net> Date: Fri, 27 Feb 1998 16:56:38 +0100 From: Eivind Eklund To: fs@FreeBSD.ORG Subject: Re: syncer / SMP question References: <19980227164859.25557@follo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <19980227164859.25557@follo.net>; from Eivind Eklund on Fri, Feb 27, 1998 at 04:48:59PM +0100 Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Fri, Feb 27, 1998 at 04:48:59PM +0100, Eivind Eklund wrote: > I was looking at implementing an incremental syncer for UFS, as a sort > of "let's get to know the FS-code" project, and noticed something that > looked like really strange code in the sync() syscall. Is there any > reason why the below wouldn't be a benign change? The extra > simplelock-call looks especially weird - it looks like either the lock > is released somewhere else, or we'll have the mountlist locked many > times. I looked a bit further. If the sync patch is incorrect (ie, the lock can't be moved that way), is there any reason why this simple_lock(&mountlist_slock); for (mp = mountlist.cqh_first; mp != (void *)&mountlist; mp = nmp) { if (vfs_busy(mp, LK_NOWAIT, &mountlist_slock, p)) { >>>>>>> nmp = mp->mnt_list.cqe_next; continue; >>>>>>> } is not a race-condition? I'm not certain I get all of this. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message