From owner-freebsd-rc@FreeBSD.ORG Mon Jul 1 09:33:38 2013 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 398F5FD5 for ; Mon, 1 Jul 2013 09:33:38 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 2BC231CAD for ; Mon, 1 Jul 2013 09:33:37 +0000 (UTC) Received: from alph.d.allbsd.org (p3086-ipbf906funabasi.chiba.ocn.ne.jp [122.26.46.86]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r619XJPC030001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 1 Jul 2013 18:33:29 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r619XGWm083831; Mon, 1 Jul 2013 18:33:19 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 01 Jul 2013 18:33:06 +0900 (JST) Message-Id: <20130701.183306.662470761675862613.hrs@allbsd.org> To: jilles@stack.nl Subject: Re: Proposal: multi-instance and self-contained rc.d script From: Hiroki Sato In-Reply-To: <20130630221032.GB43309@stack.nl> References: <20130701.062953.1443190655468739608.hrs@allbsd.org> <20130630221032.GB43309@stack.nl> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Jul__1_18_33_06_2013_982)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 01 Jul 2013 18:33:30 +0900 (JST) X-Spam-Status: No, score=-89.2 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,ONLY1HOPDIRECT,QENCPTR1,RCVD_IN_PBL,SAMEHELOBY2HOP, USER_IN_WHITELIST,X_CHINESE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jul 2013 09:33:38 -0000 ----Security_Multipart(Mon_Jul__1_18_33_06_2013_982)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jilles Tjoelker wrote in <20130630221032.GB43309@stack.nl>: ji> On Mon, Jul 01, 2013 at 06:29:53AM +0900, Hiroki Sato wrote: ji> > In the patch, killing the processes without pid file does not work ji> > well yet. This can be improved. ji> ji> I don't think it is possible to fix that properly. Killing processes by ji> name has a high risk of killing unrelated processes in any case. Yes. The current patch does not care about it at all, so probably we need to make it less harmful. ji> > b) Make rc.d/foo always have rc.d/foo(8) manual page. ji> ji> However, I don't like another set of manual pages. Why? rc.conf(5) manual page has been bloated. What do you think about the best place to document variables and non-standard script arguments? ji> ji> > That's all. Both changes are fully backward compatible and I believe ji> > they improve flexibility and manageability of rc.d scripts. ji> ji> > An example of rc.d/routed(8) manual page is also attached. If these ji> > changes are acceptable, I would like to split the current (lengthy) ji> > rc.conf(5) manual page into rc.d/foo(8). ji> ji> > Index: etc/rc.subr ji> > =================================================================== ... (snip) Thank you for your feedback about the code! I will revise the patch and post it again. -- Hiroki ----Security_Multipart(Mon_Jul__1_18_33_06_2013_982)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlHRTNIACgkQTyzT2CeTzy11WwCfRfk2oV62WWDBOYnoasS52rX3 x7wAoLHEsd1gTr+UIERba7cNwfheKLks =5E6A -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jul__1_18_33_06_2013_982)----