Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Jul 2009 16:38:25 +0200
From:      Rene Ladan <rene@freebsd.org>
To:        Kostik Belousov <kostikbel@gmail.com>
Cc:        freebsd-fs@freebsd.org
Subject:   Re: kern/136945: [ufs] [lor] filedesc structure/ufs (poll)
Message-ID:  <e890cae60907300738n115f3cd2lb747d230fa6cb994@mail.gmail.com>
In-Reply-To: <20090730132121.GH1884@deviant.kiev.zoral.com.ua>
References:  <200907271400.n6RE05Rv056472@freefall.freebsd.org> <200907290742.20838.jhb@freebsd.org> <e890cae60907290820i65abae2fracbc5ab935465089@mail.gmail.com> <200907291135.17569.jhb@freebsd.org> <e890cae60907300205v5d3d5586qe86969bd28fe8621@mail.gmail.com> <20090730092507.GF1884@deviant.kiev.zoral.com.ua> <e890cae60907300555x63de4a0dva503171d8fe2d3e6@mail.gmail.com> <20090730132121.GH1884@deviant.kiev.zoral.com.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
2009/7/30 Kostik Belousov <kostikbel@gmail.com>:
> On Thu, Jul 30, 2009 at 02:55:48PM +0200, Rene Ladan wrote:
>>
>> FreeBSD 8.0-BETA2 #3: Thu Jul 30 13:29:46 CEST 2009
>>
>> lock order reversal:
>> =A01st 0xffffff00510a5d80 ufs (ufs) @ /usr/src/sys/kern/kern_exec.c:570
>> =A02nd 0xffffff0002dfe248 filedesc structure (filedesc structure) @ /usr=
/src/sys/kern/kern_descrip.c:1864
>> KDB: stack backtrace:
>> db_trace_self_wrapper() at db_trace_self_wrapper+0x2a
>> _witness_debugger() at _witness_debugger+0x49
>> witness_checkorder() at witness_checkorder+0x7ea
>> _sx_xlock() at _sx_xlock+0x44
>> setugidsafety() at setugidsafety+0x40
>> kern_execve() at kern_execve+0xf22
>> execve() at execve+0x38
>> syscall() at syscall+0x1af
>> Xfast_syscall() at Xfast_syscall+0xe1
>> --- syscall (59, FreeBSD ELF64, execve), rip =3D 0x8007c3d0c, rsp =3D 0x=
7fffffffec48, rbp =3D 0x7fffffffed50 ---
>
> For this one, please replace the order of lines 676 and 677 in
> sys/kern/kern_exec.c, that is make it be
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0VOP_UNLOCK(imgp->vp, 0);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0setugidsafety(td);
> instead of
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0VOP_UNLOCK(imgp->vp, 0);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0setugidsafety(td);
>

This patch seems to solve the LORs I got right after boot (only one
about wpi is left which I already reported).

Ren=E9



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e890cae60907300738n115f3cd2lb747d230fa6cb994>