From owner-cvs-all Tue Nov 21 0:51:35 2000 Delivered-To: cvs-all@freebsd.org Received: from anchor-post-33.mail.demon.net (anchor-post-33.mail.demon.net [194.217.242.91]) by hub.freebsd.org (Postfix) with ESMTP id 27F1937B4D7; Tue, 21 Nov 2000 00:51:31 -0800 (PST) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by anchor-post-33.mail.demon.net with esmtp (Exim 2.12 #1) id 13y99B-000GUP-0X; Tue, 21 Nov 2000 08:51:26 +0000 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id IAA85702; Tue, 21 Nov 2000 08:54:24 GMT (envelope-from dfr@nlsystems.com) Date: Tue, 21 Nov 2000 08:52:23 +0000 (GMT) From: Doug Rabson To: Andrew Gallatin Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/alpha/pci cia.c In-Reply-To: <200011210325.TAA03038@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 20 Nov 2000, Andrew Gallatin wrote: > gallatin 2000/11/20 19:25:31 PST > > Modified files: > sys/alpha/pci cia.c > Log: > fix isa DMA on pyxis based machines: > - move the call to cia_init_sgmap() to after we've determined if we're a pyxis > - convert needed splhigh() in cia_sgmap_invalidate_pyxis() to disable_intr() > > Previously, any isa DMA on a pyxis based machine would cause a panic > in cia_sgmap_invalidate_pyxis() because the pyxis workaround was never > setup. > > - while i'm at it, convert needed splhigh() in cia_swiz_set_hae_mem to > disable_intr() I'm just testing a patch to use a mutex in sgmap.c to protect the sgmap data structures. This ought to be sufficient to protect the cia bits too - I'll see what happens if I remove the disable_intr() bits from the cia sgmap code. -- Doug Rabson Mail: dfr@nlsystems.com Phone: +44 20 8348 6160 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message