From owner-freebsd-arch Fri Jul 7 11:20: 8 2000 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id B411C37BF17; Fri, 7 Jul 2000 11:20:01 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.9.3/8.9.3) with SMTP id OAA69181; Fri, 7 Jul 2000 14:19:58 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 7 Jul 2000 14:19:57 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Marius Bendiksen Cc: Adrian Chadd , Matthew Dillon , Alfred Perlstein , freebsd-arch@FreeBSD.ORG Subject: Re: Alterations to vops In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 7 Jul 2000, Marius Bendiksen wrote: > Like I stated in the original post; currently, certain operations scan > through a number of blocks in kernel space. I would like to be able to > add an off_t to the argument list of said operations, set to VNOVAL by > the caller, then initialized by the VOP, and incremented by it on each > pass. The VOP will return a new error code (ERETRY) when the pass only > partially completed, and the library will iterate. VNOVAL is evil. This is not an opinion about the general point your making, just a comment on the poor design of vop_{get,set}attr. Right now, collisions between the usable data space of attributes and the VNOVAL constant can cause serious pain. For example, chowning a file to the integer value of VNOVAL :-). Ideally, in my mind, calls to vop_setattr() would be replaced with calls to vop_setextattr, allowing us to get rid of the VNOVAL use. That said, I'm not sure I expect that to happen, and there would be namespace issues if it did. robert@fledge.watson.org http://www.watson.org/~robert/ PGP key fingerprint: AF B5 5F FF A6 4A 79 37 ED 5F 55 E9 58 04 6A B1 TIS Labs at Network Associates, Safeport Network Services To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message