From owner-svn-src-user@FreeBSD.ORG Sun Feb 22 20:11:10 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5AB31106566C; Sun, 22 Feb 2009 20:11:10 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 490DC8FC1A; Sun, 22 Feb 2009 20:11:10 +0000 (UTC) (envelope-from alc@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n1MKBA8V005435; Sun, 22 Feb 2009 20:11:10 GMT (envelope-from alc@svn.freebsd.org) Received: (from alc@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n1MKBA3i005434; Sun, 22 Feb 2009 20:11:10 GMT (envelope-from alc@svn.freebsd.org) Message-Id: <200902222011.n1MKBA3i005434@svn.freebsd.org> From: Alan Cox Date: Sun, 22 Feb 2009 20:11:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r188931 - user/alc/pagelock/sys/fs/tmpfs X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Feb 2009 20:11:10 -0000 Author: alc Date: Sun Feb 22 20:11:10 2009 New Revision: 188931 URL: http://svn.freebsd.org/changeset/base/188931 Log: Eliminate unnecessary page queues locking. Modified: user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c Modified: user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c ============================================================================== --- user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c Sun Feb 22 19:59:41 2009 (r188930) +++ user/alc/pagelock/sys/fs/tmpfs/tmpfs_vnops.c Sun Feb 22 20:11:10 2009 (r188931) @@ -569,9 +569,7 @@ lookupvpg: if (vm_page_sleep_if_busy(vpg, FALSE, "tmfsmw")) goto lookupvpg; vm_page_busy(vpg); - vm_page_lock_queues(); vm_page_undirty(vpg); - vm_page_unlock_queues(); VM_OBJECT_UNLOCK(vobj); error = uiomove_fromphys(&vpg, offset, tlen, uio); } else { @@ -605,12 +603,12 @@ nocache: out: if (vobj != NULL) VM_OBJECT_LOCK(vobj); - vm_page_lock_queues(); if (error == 0) { vm_page_set_validclean(tpg, offset, tlen); vm_page_zero_invalid(tpg, TRUE); vm_page_dirty(tpg); } + vm_page_lock_queues(); vm_page_unwire(tpg, TRUE); vm_page_unlock_queues(); vm_page_wakeup(tpg);