From owner-cvs-all@FreeBSD.ORG Mon Jul 14 02:30:17 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8DF2A37B401; Mon, 14 Jul 2003 02:30:17 -0700 (PDT) Received: from lambda.foldr.org (lambda.foldr.org [198.78.66.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7CBC143F3F; Mon, 14 Jul 2003 02:30:16 -0700 (PDT) (envelope-from vs@foldr.org) Received: from theater.foldr.org (root@pD9509C99.dip.t-dialin.net [217.80.156.153]) by lambda.foldr.org (8.12.9/8.12.8) with ESMTP id h6E9UAbO025634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Jul 2003 11:30:13 +0200 (CEST) (envelope-from vs@foldr.org) Received: from theater.dynamic.foldr.org (vs@localhost.foldr.org [127.0.0.1]) by theater.foldr.org (8.12.9/8.12.8) with ESMTP id h6E9TDcu003784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 Jul 2003 11:29:15 +0200 (CEST) (envelope-from vs@theater.dynamic.foldr.org) Received: (from vs@localhost) by theater.dynamic.foldr.org (8.12.9/8.12.9/Submit) id h6E9TC18003783; Mon, 14 Jul 2003 11:29:12 +0200 (CEST) (envelope-from vs) Date: Mon, 14 Jul 2003 11:29:11 +0200 From: Volker Stolz To: Alexander Langer , kris@freebsd.org Message-ID: <20030714092911.GB3714@theater.foldr.org> References: <20030714072236.GK14622@fump.kawo2.rwth-aachen.de> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="6sX45UoQRIJXqkqR" Content-Disposition: inline In-Reply-To: <20030714072236.GK14622@fump.kawo2.rwth-aachen.de> X-PGP-Key: finger vs@foldr.org X-PGP-Id: 0x3FD1B6B5 User-Agent: Mutt/1.5.1i cc: cvs-ports@freebsd.org cc: cvs-all@freebsd.org cc: ports-committers@freebsd.org Subject: Re: (fwd) Re: cvs commit: ports/x11-toolkits/open-motif/files patch-lib::Xm::ColorS.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jul 2003 09:30:18 -0000 --6sX45UoQRIJXqkqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 14, 2003 at 09:22:36AM +0200, Alexander Langer wrote: > ----- Forwarded message from Kris Kennaway ----- > > 'colordemo' from open-motif can be used to select colors by either RG= B values > > or from the file rgb.txt. However, the underlying library doesn't hon= our XBASE > > and looks for the file in the wrong place. > > =20 > Are you sure this patch is correct? How does X11BASE get transmuted > into LIBDIR (which defaults to /usr/lib)? LIBDIR gets set in the Makefile by means of configure and is handled in the= same way in similar places throughout the source, e.g. openmotif-2.2.2/lib/Xm/Xm= os.c I added the #ifndef LIBDIR lines so that in case somebody else picks up our= patches or chooses to configure this thing in a different way, he gets the behaviour o= f the original source code. Notice the -DLIBDIR in the actual command being execu= ted from the FreeBSD port: cc -DHAVE_CONFIG_H -I. -I. -I../../include -I./.. -DXMBINDDIR_FALLBACK=3D\"= /usr/X11R6/lib/X11/bindings\" -DINCDIR=3D\"/usr/X11R6/include/X11\" -DLIBDI= R=3D\"/usr/X11R6/lib/X11\" -I/usr/X11R6/include -DCSRG_BASED -DXUSE_MTSAFE_= API -DXNO_MTSAFE_PWDAPI -O -pipe -O -pipe -W -march=3Dpentiumpro -Wall -Wno= -unused -Wno-comment -c ColorS.c -fPIC -DPIC -o .libs/ColorS.lo Do you see a specific case where this breaks? Regards, Volker --=20 Volker Stolz * stolz@i2.informatik.rwth-aachen.de * PGP + S/MIME=20 --6sX45UoQRIJXqkqR Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iQCVAwUBPxJ35xLpPok/0ba1AQE/EQP+M+0HsQRGSA7Ft3FyU1ojWmY49VoA/pEj 523FDxMo3LNsSaRMEbaw03cFZWA6WBzcdU/BnyYZb0wfrU8evWbdYbrNNHW2iPML Qy5v15IHLHRbAG/9Zbn9djeKDRkrRACxg/V68aqENxnBK1NFg7k9A4wZ4fPYJaKh BXaQ7JqGSkw= =aqyY -----END PGP SIGNATURE----- --6sX45UoQRIJXqkqR--