From owner-freebsd-eclipse@FreeBSD.ORG Fri Sep 21 15:51:46 2007 Return-Path: Delivered-To: freebsd-eclipse@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB13B16A419 for ; Fri, 21 Sep 2007 15:51:46 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id 9535B13C455 for ; Fri, 21 Sep 2007 15:51:46 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.13.1/8.13.3) with ESMTP id l8LFpjeS069441 for ; Fri, 21 Sep 2007 08:51:45 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.13.1/8.13.3/Submit) id l8LFpjn9069440 for freebsd-eclipse@FreeBSD.org; Fri, 21 Sep 2007 08:51:45 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Fri, 21 Sep 2007 08:51:44 -0700 From: Greg Lewis To: freebsd-eclipse@FreeBSD.org Message-ID: <20070921155144.GA69397@misty.eyesbeyond.com> References: <46E80076.60205@buzmo.com> <20070913.115518.38718088.ken@tydfam.jp> <46E8C397.1040103@buzmo.com> <20070913.144711.35011923.ken@tydfam.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070913.144711.35011923.ken@tydfam.jp> User-Agent: Mutt/1.4.2.2i Cc: Subject: Re: Eclipse-Europa Web-browser X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 15:51:46 -0000 G'day all, I grabbed the two versions of the Eclipse 3.3 port that seem to have been mentioned on the list and am looking at committing one to eclipse-devel. One thing that stands out immediately is files/launchersrc.zip. What is this and where did it come from? Committing a large binary file to the ports repo is pretty much going to be a non-starter. I suspect this should actually be a DISTFILE. Other than that it looks pretty reasonable. I cleaned up some portlint warnings and so on, but they were fairly minimal. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org