From owner-freebsd-arch@FreeBSD.ORG Sun Jun 15 11:08:20 2003 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A89437B401 for ; Sun, 15 Jun 2003 11:08:20 -0700 (PDT) Received: from dhcp01.pn.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id A097943FBF for ; Sun, 15 Jun 2003 11:08:19 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h5FI8Jqh015728; Sun, 15 Jun 2003 11:08:19 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h5FI8IRn015727; Sun, 15 Jun 2003 11:08:18 -0700 (PDT) Date: Sun, 15 Jun 2003 11:08:18 -0700 From: Marcel Moolenaar To: Ian Dowse Message-ID: <20030615180818.GA15538@dhcp01.pn.xcllnt.net> References: <200306151406.aa36218@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200306151406.aa36218@salmon.maths.tcd.ie> User-Agent: Mutt/1.5.4i cc: freebsd-arch@freebsd.org Subject: Re: Message buffer and printf reentrancy patch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2003 18:08:20 -0000 On Sun, Jun 15, 2003 at 02:06:50PM +0100, Ian Dowse wrote: > > Index: sys/sys/msgbuf.h > =================================================================== > RCS file: /dump/FreeBSD-CVS/src/sys/sys/msgbuf.h,v > retrieving revision 1.20 > diff -u -r1.20 msgbuf.h > --- sys/sys/msgbuf.h 28 Mar 2003 02:50:10 -0000 1.20 > +++ sys/sys/msgbuf.h 15 Jun 2003 12:00:45 -0000 > @@ -41,16 +41,32 @@ > #define MSG_MAGIC 0x063062 > u_int msg_magic; > int msg_size; /* size of buffer area */ > - int msg_bufx; /* write pointer */ > - int msg_bufr; /* read pointer */ > + int msg_wseq; /* write sequence number */ > + int msg_rseq; /* read sequence number */ > + int msg_seqmod; /* range for sequence numbers */ > char *msg_ptr; /* pointer to buffer */ > u_int msg_cksum; /* checksum of contents */ > }; Nit: please move the msg_ptr field before the int fields. There used to be no internal padding, but on 64-bit platforms with an odd number of ints, this will be the case. -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net