From owner-freebsd-hackers@FreeBSD.ORG Fri Mar 18 05:53:54 2005 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7DCA116A4CE for ; Fri, 18 Mar 2005 05:53:54 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1891C43D39 for ; Fri, 18 Mar 2005 05:53:54 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.3/8.13.1) with ESMTP id j2I5rlcD040826; Fri, 18 Mar 2005 00:53:47 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.3/8.13.1/Submit) id j2I5rlIh040825; Fri, 18 Mar 2005 00:53:47 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Fri, 18 Mar 2005 00:53:47 -0500 From: David Schultz To: Ted Unangst Message-ID: <20050318055347.GA40787@VARK.MIT.EDU> Mail-Followup-To: Ted Unangst , hackers@FreeBSD.ORG References: <42360141.3080104@coverity.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42360141.3080104@coverity.com> cc: hackers@FreeBSD.ORG Subject: Re: some bugs in the kernel X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2005 05:53:54 -0000 On Mon, Mar 14, 2005, Ted Unangst wrote: > These bugs were found using the Coverity Prevent static analysis tool. [...] Thanks for reporting these! It's great that your tools have been finding all these obscure bugs before users do. All of these should be fixed now, except for the if_ti bug, which I've forwarded to wpaul@. pjd 2005-03-16 20:48:13 UTC FreeBSD src repository Modified files: sys/geom geom_bsd.c Log: Plug memory leak. Submitted by: Ted Unangst Found by: Coverity Prevent analysis tool Approved by: phk MFC after: 3 days Revision Changes Path 1.73 +1 -2 src/sys/geom/geom_bsd.c das 2005-03-18 05:43:34 UTC FreeBSD src repository Modified files: sys/dev/hptmv gui_lib.c Log: Don't read past the end of pVDevice[]. (Previously, we would iterate twice as many times as there were entries in the array.) Spotted by: Ted Unangst using the Coverity Prevent static analysis tool Reviewed by: scottl Revision Changes Path 1.4 +1 -1 src/sys/dev/hptmv/gui_lib.c das 2005-03-18 05:43:31 UTC FreeBSD src repository Modified files: sys/dev/hptmv entry.c Log: Don't write past the end of the VendorId field (and into the ProductId field). Spotted by: Ted Unangst using the Coverity Prevent static analysis tool Reviewed by: scottl Revision Changes Path 1.7 +1 -1 src/sys/dev/hptmv/entry.c imp 2005-03-15 22:53:31 UTC FreeBSD src repository Modified files: sys/dev/pci pci.c Log: If bus_generic_susped returns an error, devlist is not freed. Free it. Submitted by: Ted Unangst (using the Coverity Prevent analysis tool) Revision Changes Path 1.281 +3 -1 src/sys/dev/pci/pci.c das 2005-03-18 05:43:37 UTC FreeBSD src repository Modified files: sys/dev/mlx mlx_pci.c Log: If mlx_attach() returns an error, don't free sc again. Spotted by: Ted Unangst using the Coverity Prevent static analysis tool Reviewed by: scottl Revision Changes Path 1.21 +1 -3 src/sys/dev/mlx/mlx_pci.c