From owner-freebsd-current Sun Nov 11 4:11:50 2001 Delivered-To: freebsd-current@freebsd.org Received: from marvin.nildram.co.uk (marvin.nildram.co.uk [195.112.4.71]) by hub.freebsd.org (Postfix) with SMTP id 9EB9237B41F for ; Sun, 11 Nov 2001 04:11:44 -0800 (PST) Received: (qmail 29507 invoked from network); 11 Nov 2001 12:11:43 -0000 Received: from tgeusch.dial.nildram.co.uk (HELO nermal.unix-consult.com) (195.149.29.39) by marvin.nildram.co.uk with SMTP; 11 Nov 2001 12:11:43 -0000 Received: (qmail 95939 invoked from network); 11 Nov 2001 12:11:19 -0000 Received: from odie.unix-consult.com (192.168.0.2) by nermal.unix-consult.com with SMTP; 11 Nov 2001 12:11:19 -0000 Received: by odie.unix-consult.com (Postfix, from userid 1002) id 14E3FB4; Sun, 11 Nov 2001 12:11:02 +0000 (GMT) Date: Sun, 11 Nov 2001 12:11:01 +0000 From: Timo Geusch To: current@freebsd.org Subject: NFS rpc.lockd bug in nfs client mode - patch attached. Message-ID: <20011111121101.A875@odie.unix-consult.com> Mail-Followup-To: Timo Geusch , current@freebsd.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline User-Agent: Mutt/1.2.5i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline All, I'm running -current on my main box, NFS mounting home directories from my -stable box. The -current box is configured as an NFS client only as it does not serve anything. The -stable box is configured as an NFS server only. In this configuration, running rpc.statd and rpc.lockd on both boxes (manually started on the -current box as it does not support rpc.lockd & statd via /etc/rc in nfs client mode[1]), rpc.lockd core dumps reliably on the -current client when unlocking a file on the server. I have tracked this down as a problem with too few parameters being passed to lock_answer (file kern.c). The attached patch fixes the problem for me by bringing the parameters in line with the other calls to lock_answer. Can someone with commit priviledges please review the patch and commit it if it does the right thing? Thanks, Timo [1] I can supply a rough patch to fix this problem, but I'm not happy with it. If someone is interested in reviewing the patch, please drop me an email and I'll get it off to you. --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="lock_proc.diff" --- lock_proc.c.old Sun Oct 14 19:36:35 2001 +++ lock_proc.c Sun Nov 11 11:57:35 2001 @@ -763,7 +763,7 @@ if (debug_level) log_from_addr("nlm_unlock_res", rqstp); - lock_answer(&arg->cookie, arg->stat.stat, NLM_VERS); + lock_answer(-1, &arg->cookie, arg->stat.stat, NULL, NLM_VERS); return (NULL); } --7AUc2qLy4jB3hD7Z-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message