From owner-freebsd-current@FreeBSD.ORG  Tue May  9 03:30:39 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1DFB016A43D
	for <current@freebsd.org>; Tue,  9 May 2006 03:30:39 +0000 (UTC)
	(envelope-from deischen@freebsd.org)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 51DA343D5A
	for <current@freebsd.org>; Tue,  9 May 2006 03:30:38 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.ntplx.net (8.13.6/8.13.6/NETPLEX) with ESMTP id k493UbMf025192; 
	Mon, 8 May 2006 23:30:37 -0400 (EDT)
Date: Mon, 8 May 2006 23:30:37 -0400 (EDT)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: John Birrell <jb@what-creek.com>
In-Reply-To: <20060509010531.GA81623@what-creek.com>
Message-ID: <Pine.GSO.4.64.0605082324280.13935@sea.ntplx.net>
References: <Pine.GSO.4.64.0605081648270.11616@sea.ntplx.net>
	<445FB11C.1000309@samsco.org>
	<Pine.GSO.4.64.0605081700490.11616@sea.ntplx.net>
	<20060508.174813.89129442.imp@bsdimp.com>
	<Pine.GSO.4.64.0605081954550.11616@sea.ntplx.net>
	<20060509000928.GA81282@what-creek.com>
	<Pine.GSO.4.64.0605082032430.11616@sea.ntplx.net>
	<20060509010531.GA81623@what-creek.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
Cc: current@freebsd.org
Subject: DTRACE mods to libpthread (Was Re: Shared library version bump?)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 May 2006 03:30:39 -0000

On Tue, 9 May 2006, John Birrell wrote:

> On Mon, May 08, 2006 at 08:37:18PM -0400, Daniel Eischen wrote:
>> Are you sure you're not talking about mutex(9F) on Solaris ;-)
>
> I don't have an installed version of Solaris. It hates all my
> machines. Even the Dells. Heh. So I don't get to look at man pages.
> Just the source.
>
>> I can see mutex_held in Solaris 10 /lib/libthread.so.1, but I
>> don't see any rwlock_held or rwlock_owned.
>
> It'll be one of their internal interfaces.

Yeah, there wasn't anything I could see that was visible in libpthread
for rwlocks.

> I did this:
>
> <http://perforce.freebsd.org/fileDiffView.cgi?FSPC=//depot/projects/dtrace/src/include/pthread%5fnp.h,//depot/projects/dtrace/src/lib/libpthread/pthread.map,//depot/projects/dtrace/src/lib/libpthread/thread/thr%5fmutex.c,//depot/projects/dtrace/src/lib/libpthread/thread/thr%5frwlock.c&REV=2%202%202%202&ACT=edit%20edit%20edit%20edit&CH=95271>
>
> And then #defined their names/macros to ours.
>
> I hope that link works.

That looks OK, but please use _pthread_foo() and use a weak reference
to it with pthread_foo().  This convention is modeled after Solaris'
symbol naming scheme ;-).

-- 
DE