Date: Wed, 24 Apr 1996 10:58:58 -0400 From: "Frank E. Terhaar-Yonkers" <fty@mcnc.org> To: sos@FreeBSD.ORG Cc: current@FreeBSD.ORG, freebsd-current@FreeBSD.ORG Subject: Re: minor syscons bogon Message-ID: <199604241458.KAA20962@robin.mcnc.org.mcnc.org>
next in thread | raw e-mail | index | archive | help
That's fine .. >There is no real saving in mucking with MAXCONS, all vty's are dynamically >allocated... >Besides MAXCONS are to meant to be fooled around with, its a value >used as a max value... > >> Would someone kindly commit this patch so others don't fall in the same >> hole? I believe pcvt has the same bug, but haven't looked at it. > >NO, this breaks the console device /dev/console ! >(and its not a bug) The fix may not be correct if it does in fact break /dev/console. But the scenario IS A BUG. The kernel should not allow an open/write to an unconfigured device with obviously bad results. > >> - Frank >> >> *** syscons.c.orig Thu Feb 8 04:25:44 1996 >> --- syscons.c Wed Apr 24 05:31:05 1996 >> *************** >> *** 305,311 **** >> >> if (!init_done) >> return(NULL); >> ! if (unit > MAXCONS || unit < 0) >> return(NULL); >> if (unit == MAXCONS) >> return CONSOLE_TTY; >> --- 305,311 ---- >> >> if (!init_done) >> return(NULL); >> ! if (unit >= MAXCONS || unit < 0) >> return(NULL); >> if (unit == MAXCONS) >> return CONSOLE_TTY; >> >> \\\\////\\\\////\\\\\////\\\\\////\\\\////\\\\////\\\\////\\\\////\\\\////\\\\ >> Frank Terhaar-Yonkers, Manager >> High Performance Computing and Communications Research >> MCNC >> PO Box 12889 3021 Cornwallis Road >> Research Triangle Park, North Carolina 27709-2889 >> fty@mcnc.org voice (919)248-1417 FAX (919)248-1455 >> >> http://www.mcnc.org/hpcc.html >> > > >-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- >Soren Schmidt (sos@FreeBSD.org) FreeBSD Core Team > So much code to hack -- so little time. > \\\\////\\\\////\\\\\////\\\\\////\\\\////\\\\////\\\\////\\\\////\\\\////\\\\ Frank Terhaar-Yonkers, Manager High Performance Computing and Communications Research MCNC PO Box 12889 3021 Cornwallis Road Research Triangle Park, North Carolina 27709-2889 fty@mcnc.org voice (919)248-1417 FAX (919)248-1455 http://www.mcnc.org/hpcc.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199604241458.KAA20962>