From owner-svn-ports-all@FreeBSD.ORG  Thu Jul 24 15:49:34 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 51493F80;
 Thu, 24 Jul 2014 15:49:34 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3EAF62DD5;
 Thu, 24 Jul 2014 15:49:34 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s6OFnYwG007648;
 Thu, 24 Jul 2014 15:49:34 GMT (envelope-from adamw@svn.freebsd.org)
Received: (from adamw@localhost)
 by svn.freebsd.org (8.14.8/8.14.8/Submit) id s6OFnXed007646;
 Thu, 24 Jul 2014 15:49:33 GMT (envelope-from adamw@svn.freebsd.org)
Message-Id: <201407241549.s6OFnXed007646@svn.freebsd.org>
From: Adam Weinberger <adamw@FreeBSD.org>
Date: Thu, 24 Jul 2014 15:49:33 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r362809 - head/games/greed
X-SVN-Group: ports-head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jul 2014 15:49:34 -0000

Author: adamw
Date: Thu Jul 24 15:49:33 2014
New Revision: 362809
URL: http://svnweb.freebsd.org/changeset/ports/362809
QAT: https://qat.redports.org/buildarchive/r362809/

Log:
  This port was not stage-safe as it was making direct writes to /var. Fix that,
  along with making do-install substantially easier to read. While here, stop
  muting the build command.

Modified:
  head/games/greed/Makefile
  head/games/greed/pkg-plist

Modified: head/games/greed/Makefile
==============================================================================
--- head/games/greed/Makefile	Thu Jul 24 15:47:04 2014	(r362808)
+++ head/games/greed/Makefile	Thu Jul 24 15:49:33 2014	(r362809)
@@ -15,16 +15,15 @@ LICENSE=	BSD3CLAUSE
 SCOREFILE?=	/var/games/greed.hs
 CFLAGS+=	-DSCOREFILE=\"${SCOREFILE}\" -DNOTBSD -DRELEASE=\"${PORTVERSION}\"
 LDFLAGS+=	-lcurses
+PLIST_SUB+=	SCOREFILE=${SCOREFILE:S|^/||}
 
 do-build:
-	@cd ${WRKSRC}&&${CC} ${CFLAGS} -o greed greed.c ${LDFLAGS}
+	(cd ${WRKSRC} && ${CC} ${CFLAGS} -o greed greed.c ${LDFLAGS})
 
 do-install:
 	${INSTALL_PROGRAM} -m 2555 -o root -g games ${WRKSRC}/greed ${STAGEDIR}${PREFIX}/bin/
 	${INSTALL_MAN} ${WRKSRC}/greed.6 ${STAGEDIR}${MAN6PREFIX}/man/man6/
-	@a=${SCOREFILE};[ -f $$a ]||:>$$a&&${CHOWN} root:games $$a&&${CHMOD} 664 $$a
-	@${ECHO_CMD} '@exec a=${SCOREFILE};[ -f $$a ]||:>$$a&&\
-		${CHOWN} root:games $$a&&${CHMOD} 664 $$a' >> ${TMPPLIST}
-	@${ECHO_CMD} '@unexec a=${SCOREFILE};[ -s $$a ]||${RM} -f $$a' >> ${TMPPLIST}
+	@${MKDIR} ${STAGEDIR}${SCOREFILE:H}
+	${TOUCH} ${STAGEDIR}${SCOREFILE}.sample
 
 .include <bsd.port.mk>

Modified: head/games/greed/pkg-plist
==============================================================================
--- head/games/greed/pkg-plist	Thu Jul 24 15:47:04 2014	(r362808)
+++ head/games/greed/pkg-plist	Thu Jul 24 15:49:33 2014	(r362809)
@@ -1,2 +1,6 @@
 bin/greed
 man/man6/greed.6.gz
+@cwd /
+@group games
+@mode 664
+@sample %%SCOREFILE%%.sample