From owner-freebsd-arm@freebsd.org Fri Jan 22 23:13:42 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84637A8D1CE; Fri, 22 Jan 2016 23:13:42 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0144.outbound.protection.outlook.com [157.56.111.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E73BE199E; Fri, 22 Jan 2016 23:13:41 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from BY2PR05CA036.namprd05.prod.outlook.com (10.141.250.26) by BL2PR05MB051.namprd05.prod.outlook.com (10.255.228.151) with Microsoft SMTP Server (TLS) id 15.1.365.19; Fri, 22 Jan 2016 22:39:12 +0000 Received: from BN1AFFO11OLC002.protection.gbl (2a01:111:f400:7c10::126) by BY2PR05CA036.outlook.office365.com (2a01:111:e400:2c5f::26) with Microsoft SMTP Server (TLS) id 15.1.390.13 via Frontend Transport; Fri, 22 Jan 2016 22:39:12 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=juniper.net; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BN1AFFO11OLC002.mail.protection.outlook.com (10.58.53.73) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Fri, 22 Jan 2016 22:39:12 +0000 Received: from stevek-ubuntu.jnpr.net (172.25.4.171) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server id 14.3.123.3; Fri, 22 Jan 2016 14:39:11 -0800 Date: Fri, 22 Jan 2016 17:39:06 -0500 From: Steve Kiernan To: Stanislav Galabov CC: , Subject: Re: SPI geom_flashmap/fdt_slicer support, FDT 'resets=' support and a move of ohci_fdt.c Message-ID: <20160122173906.147bb7c2@stevek-ubuntu.jnpr.net> In-Reply-To: References: Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11OLC002; 1:DVUj8XKBCTwF8HUZfMW8Sm03OCiERZZ7Jc69VOmKetRpPqwpnDJDrItsMy+yyKqygL6jGV/UqvFOPwWn96LVgVXasYpt4PFQZ+h99pq5Nv+jGNyF/jNUBi6jzQkwWj8ZAtGm50aVujJ7kftdLgSNNxHQAXY1keYiuEzi3ivAsUlkcZcLReHvbgNB6B2hTaV0U4n3uE4mz8LANB1EtbNogY0aOTnmjQj6xRI/AtRPTxJqBd08KSU9r1J48k/j3MTDajE3TmZajPkE03Vx40VqIs4qBIi7VKt9xemOSHvJh6v6tdPExhV4imozRGcZJSn05m2Gb/oHfSA2LgxbyAmZ53nvvg7joAGBHnPyNcoIMBs4FEru8L8ojF/8loP5yP2cUO85reOtF83p2h0fMEhkhd25/AP0x9J21KsFOL0vBcs= X-Forefront-Antispam-Report: CIP:66.129.239.19; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(24454002)(199003)(53754006)(189002)(1076002)(50226001)(586003)(1096002)(6806005)(2950100001)(2906002)(4326007)(1220700001)(5003600100002)(77096005)(110136002)(15975445007)(189998001)(19580395003)(19580405001)(11100500001)(92566002)(53416004)(106466001)(69596002)(97736004)(105596002)(1411001)(47776003)(5001960100002)(81156007)(76176999)(33646002)(50986999)(50466002)(23676002)(86362001)(5820100001)(87936001)(5008740100001)(104016004)(39210200001); DIR:OUT; SFP:1102; SCL:1; SRVR:BL2PR05MB051; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 2:T/09fNEyg2sNyt7y1ejBMSEMDEmr/QO/HxX/OfFp4DOcQ0IRAH+CXZ5AhCeQ7Y2NdQlKKUGgDlObTdbTO97hHdR5pWROQ4guJQTCyOg7ntEM2P0aWch88YiMfPLYw6yRSiilcWvDgp7HL89urvx6fw==; 3:2XOqRFq3i000TP50cNhkNQiDgvk36NbwkVpdeXKjqoqk1NPMiKVboA5SqYv0ZaHO5bIPR+l2sYL7F+h/jmsjoIqasyu8+0aQ3yRpNHfTzEYfX6tde9Jh+YYLuNLECz2a779hH3nuOW9FtbrmIczfttiz4xXHMTboItiAX9eXvNrxZytGOdj8zhAtJVfqpLfYlBcDdCSi505KahgMXEbF7C2vGED0oMHo35hVaUka2Ig=; 25:dWjv7PQbsgG30Exdu/GqodD+EblTQ2PZgwpi9OKKddhGRPYa9mgGsIoyAu2CCDgDAbjCt2TAC2ZaItJtlbjWu43XV+2NdDP9nx8qeXYelL8TjAxpIuTLe/CC0qGOy3yCIEgLkYXd7yDMYjTmZTBq/8fQgyFcJ1VQYcL2bkHVV9Qldr+Zcs/9iRO3JwoWSqdvdjCIx7W7JVKmj7ECBEJaTTgKQW+OP4fNg7CrcxnH56UTV52oXUd85rZJHFxTrbmq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR05MB051; X-MS-Office365-Filtering-Correlation-Id: ee434a07-5068-4ccb-c0d3-08d3237cd9ec X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 20:exMZnafgih9yNC2zVBudi1Ou6MjJwVhz1csDcaaUACDwCsPoQ+1rZtKa7+I9nDKFQJ+tuySeYykMlgpacJ35gcFYayZwZeeMEzAlxYNpPj8B1yekIk5JI4vLGtaZON7YjGSpOTzCxO1qbGY3vEiRtE3Axsl0MCs7EqAOtMx3U/xYNXGJ1fnKq3I+kiSetvJVzC/BsbcdmRhiCIuoL1f2RO+OeYJ0/O2pOy6I8CPVz2l1djjFm28NCiaaBHOrz2xrOmQ6dfkAi8PDT4qSHwk2D5x9wfVxZX5H13cSLP2gm0pVXhcrKKKUsjMD06mO7T8ekVEePiRRX1k+4zGmIC4aRyCre+KEYS2lpI1R807iCc+85usfW9osrVJ57K6327RYMD/OQjxwLVuQq+dIVQNu6Wi05n318jPzvtFSgIS99Z2v6yyBDWPUu4dX12U4Gv6tUx8vPKcMRmuDL2nBMct7T7dP2/Ev8YSw8TvYaU6N+ShM446lnSo18A+uoizMcUcg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13018025)(13023025)(520078)(13015025)(8121501046)(13024025)(13017025)(5005006)(3002001)(10201501046); SRVR:BL2PR05MB051; BCL:0; PCL:0; RULEID:; SRVR:BL2PR05MB051; X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 4:Sf7yoBo4eJ5y6dQLFg3+Kwc2/P0zFVyIagbSvqcps/Iwkeraa1aQOBL/d8X3g9Qc6cCooeX7G3dzj/tUARrJvr7qEZvHtSzRa/cti0rm2HWUdil5fjI5g0vdBvUvbdYIvpXliOIfQD34xlDZXfWayjI0rLUCDBYTBNQPe3g0hGimNaH8J3adjSvIEmFfXWTWw1Y7WEty36lLLvEH1rhyVr2Q+efxgXz7LVKGHyh18YWhEfB7KCF9YdJ4+Q/9w50S8pS5b1i1u9iBIXKPzX60dAGjt9uaTYa3s4WXsK0QALJo64FDPjHXHG/PFBmYXj/zRTrpZyIE9O7OB0I7XxcI8MZ9s5NDxJr8SpvwZt4vLU7o6psuQV8EruLpknhnA1UQGnK1wPCrNSZAUecooO0k+O8VNqYg/jscaZNI70xkONMIbg4CV0JqAPkq4/z0Lrrfe3Lu5oSRkrGvwST6aaouWZe2rfriZ6RZOFqoLNqiHVk= X-Forefront-PRVS: 08296C9B35 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjA1TUIwNTE7MjM6RXphQmNsSHpNRkkzYzVCNlpGelVzb2pTcDVD?= =?utf-8?B?SEs4b25qZTdVd3N4NWpWZllxd1V2WkpCY0lPLys4U0xrcnBqTlpIWDJUNUNh?= =?utf-8?B?R3ZMNm1GalBYeDlQNnJaTWhyd0Qwcm4zbjNuMzZFQTBReklUZTYyWDNEdUpl?= =?utf-8?B?cU9QNFdJL21QZEpLLzJoeHI4YVB2R3F6eGpDL051VnUzaW4vc09Nc1ltRGZR?= =?utf-8?B?enVnS1VxUThIQlhBY3ZxM2pPdnR4NlBRK3cwUTNTU1cwREdFcGFVbTBEcWdG?= =?utf-8?B?ZGtXTzZjcGRlbGtxMWEwMWE1d1VNL256REN5Q2paN0YrTHdPaC9FVnlTMElW?= =?utf-8?B?REZsbkxlb0h5empxenEwdGNQaS9pd2Nad0ZUaGRQS1FxWHFSb0N6WnZqQlI5?= =?utf-8?B?d2E1RHFpdHhHUUhZNXdxb1M3bm5YSkZLY0tZYUlPbFhVMURlSmpKVHF1OWp5?= =?utf-8?B?TE5FVEkzZVA4dXpkSytXQ1h6cit2YkljRTJpK1JtOUFvRGxzL0RQcytzZHl2?= =?utf-8?B?NUdWTEc5YkpnOWJyZ1NITlBZVzNvbjdwVFViNWdSR3FCaTBobVB3UktBRHUr?= =?utf-8?B?OGw5WjFpQ0xVYWlNbytoRWdXT3h0YmlncmIyWVdnSWt6WG5pcnU0QjRSOE9y?= =?utf-8?B?K1NOd1ViQjFTOGdWQWNJdmxQdjE0L1BKRW42TElSMWRET3RES05sN3dFRGYx?= =?utf-8?B?ZzMybHNoRlIzdCtKbXZJTnZJVlhORUx0MjJQOWVNbW1XbFEzd1VQR2dOWVVu?= =?utf-8?B?bk05aWJ1OEJVSlJFR0hHeERaRWY4NEFWa2JlNXNPYkNwYmlkczJDWFdreXJJ?= =?utf-8?B?ZUxReTBOSTlPLzcrZTJyQ2tyZVFWcy9EQUZJbGlRQzRpZFpUSnVzaGN5VklL?= =?utf-8?B?Zzdna1g4VXJTMEJlTWhvSmlsVVVhWDJHaFBOMWFjb0hNNkhxbnprWVVsSHNY?= =?utf-8?B?clVJOVFHZFBXUWtzbDZPZHd6MWUzcXZuQmtQK2o1bFhBWkRSaUtuWWFtUURi?= =?utf-8?B?YU1YdnhLMHkzeWs1VFVUc0FPS1NIekR2bHpVdnM2dVNPQ1p6R0VkZ2VXUDZB?= =?utf-8?B?cEYrVXZkSFdhTWx6dEdWVDhBTkZyMjhtVWFXbjg0dHVQVDk3L0VUdVZsaWtT?= =?utf-8?B?T3BFK0xCQWU0M3ZYK2REd1Jsb1ZHQVQrTVhyb1d6MzNSK1Z3K3dLU0RrU2or?= =?utf-8?B?OCtwQzFzOUh5eGhYQ2pnMTMwMDhMZGtoQ3dJUGhYQ2pyaW5vajhFZVo1WG0w?= =?utf-8?B?VnRWbmhrajBoRkhYUjAxbVVjT1NFaVdyQmp6TUJCdERLZWhHeWdDRVJMSGZ5?= =?utf-8?B?OEhqMnNTYk1tYldPTDJSbkRCTTBsekwxdWF4NENUL0M1d0w4TnZuOXZjd1ph?= =?utf-8?B?R0d3dEJUZzIvd2w4VFFhckhXZ3MzcWdrZHBBb2d6K0dnNE4wWFFMN21xZi9F?= =?utf-8?B?d3V1WmZLRlZKSWt5SlA5eEh2WHFMUi9jWnI3V0NzMmlGdTNpM0F2V2NnYmhp?= =?utf-8?B?MnQvRFBhNENBclhtMjAxRDlCQ09VY3luRndoTUlTeGI4OVJLamQrdEsrTThJ?= =?utf-8?B?bW85d1RIbTdQR2p4U1VEM1FlQVJIZz09?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR05MB051; 5:u0PS01Wu8zba3hGIrNytJD90bIkQKPoDSPNvTLgf4y5Bpoxg2QlccShCDGf/7Si3M4WpjqhhLCNkVNdtwWd2VmE0if0X9GAMLabm9pKVGYe1DXb4ks3zyx7WbeHoneKMqIgSSuitL7CaPEcl8OVQRw==; 24:shrhv2nkSEFo1+vFjgnggnd13dM0Kil13kRXQsHH+f5guiWQwxhgUnAet4H3xtuNvTQ7Ps6mHse1FVcPTNilWPidQvs44uRaIehC0+cSqgg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2016 22:39:12.4872 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR05MB051 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 23:13:42 -0000 On Thu, 14 Jan 2016 11:01:10 +0200 Stanislav Galabov wrote: > Hi all, >=20 > First off, sorry for the cross-post, I wasn=E2=80=99t very sure where thi= s should go=E2=80=A6 >=20 > I=E2=80=99ve created 3 PRs, which enable some functionality that my work = on Ralink/Mediatek SoCs would benefit from. >=20 > 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206227 > - This enables geom_flashmap and fdt_slicer support for SPI flash chips s= upported by the mx25l driver (sys/dev/flash/mx25l.c) I see this change was committed to head, but I don't see a corresponding ch= ange to sys/conf/files to ensure fdt_slicer.c and geom_flashmap.c get compi= led. I think you also need something like the following: Index: sys/conf/files =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/conf/files (revision 294541) +++ sys/conf/files (working copy) @@ -1419,7 +1419,7 @@ dev/fdt/fdt_common.c optional fdt dev/fdt/fdt_pinctrl.c optional fdt fdt_pinctrl dev/fdt/fdt_pinctrl_if.m optional fdt fdt_pinctrl -dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand +dev/fdt/fdt_slicer.c optional fdt cfi | fdt nand | fdt mx25l dev/fdt/fdt_static_dtb.S optional fdt fdt_dtb_static \ dependency "$S/boot/fdt/dts/${MACHINE}/${FDT_DTS_FILE}" dev/fdt/simplebus.c optional fdt @@ -3010,7 +3010,7 @@ geom/geom_dump.c stfgeom_dumandard geom/geom_event.c standard geom/geom_fox.c optional geom_fox -geom/geom_flashmap.c optional fdt cfi | fdt nand +geom/geom_flashmap.c optional fdt cfi | fdt nand | fdt mx25l geom/geom_io.c standard geom/geom_kern.c standard geom/geom_map.c optional geom_map