From owner-freebsd-rc@FreeBSD.ORG Sun Nov 18 16:41:59 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2C9036E1; Sun, 18 Nov 2012 16:41:59 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 791D68FC15; Sun, 18 Nov 2012 16:41:57 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id je9so878538bkc.13 for ; Sun, 18 Nov 2012 08:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HtGnYOQtcz9/phnZ2zNRRh+oV34shJib4m6ydZdkxUE=; b=UZtlsDpqjSKUxMOcQPQotYKfDGMPkkL8hBDdsUgbjNZIREvNuF8TnHdMbydHZi+nnU THPbbmFBvZ9c7tN5Z5M0E1qY3z5LvlQHJi7L+G0hZxFUOGx8jpryqBapOg5VdENmVaTA LiWtnHn2C3jPSSxZaxzYouKwoBxZII0l6JOQONZP1lko/sDYCR+iY60UsfSVDlMyjvSr Mcspm39BuYgeE2o2u3z41XuONF06LyfJYmPAOJbze0UR4pXT0YXpNjOm5wfeyR4nL+MC MZaJG2hCL3CEt+ehCXyBDhcecnubLZEAil8uGFf8AylY2MDQBs5OruSLAxwFn4qAUMyT 3Mjw== MIME-Version: 1.0 Received: by 10.205.120.3 with SMTP id fw3mr671732bkc.40.1353256916968; Sun, 18 Nov 2012 08:41:56 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 08:41:56 -0800 (PST) Received: by 10.204.50.197 with HTTP; Sun, 18 Nov 2012 08:41:56 -0800 (PST) In-Reply-To: <20121119.001726.1901703543569641080.hrs@allbsd.org> References: <201211181450.qAIEo0L7037418@freefall.freebsd.org> <20121119.001726.1901703543569641080.hrs@allbsd.org> Date: Sun, 18 Nov 2012 16:41:56 +0000 Message-ID: Subject: Re: bin/165477: [rc] dhclient is run twice From: Chris Rees To: Hiroki Sato Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-rc@freebsd.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Nov 2012 16:41:59 -0000 On 18 Nov 2012 15:17, "Hiroki Sato" wrote: > > Chris Rees wrote > in <201211181450.qAIEo0L7037418@freefall.freebsd.org>: > > cr> The following reply was made to PR bin/165477; it has been noted by GNATS. > cr> > cr> From: Chris Rees > cr> To: Hiroki Sato > cr> Cc: wblock@freebsd.org, "freebsd-rc@freebsd.org" < freebsd-rc@freebsd.org>, > cr> "bug-followup@freebsd.org" > cr> Subject: Re: bin/165477: [rc] dhclient is run twice > cr> Date: Sun, 18 Nov 2012 14:40:00 +0000 > cr> > cr> On 17 November 2012 22:59, Hiroki Sato wrote: > cr> > > cr> > I think it is safe to remove the warning message when rc_quiet=YES. > cr> > What do you think about the attached patch? > cr> > cr> I had originally considered that, but it then makes dhclient behave > cr> differently from other scripts; nothing else respects rc_quiet in this > cr> fashion; > cr> > cr> from rc.subr: > cr> start) > cr> if [ -z "$rc_fast" -a -n "$rc_pid" ]; then > cr> echo 1>&2 "${name} already running? > cr> (pid=$rc_pid)." > cr> return 1 > cr> fi > cr> and > cr> > cr> [crees@pegasus]~/workspace/ports/musicpd% sudo service musicpd quietstart > cr> musicpd already running? (pid=83847). > > I cannot understand why the dhclient script behaves differently from > the others after patching rc.subr. Did you read the attached patch > in my previous email? I read the patch, but not the filename-- I'm sorry that Sunday afternoons are clearly not a good time for me to review code :( If you want to respect rc_quiet in rc.subr for the already running case, then I think that's fine. Chris