From owner-freebsd-current@freebsd.org Fri Apr 5 19:03:58 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA23C155823D for ; Fri, 5 Apr 2019 19:03:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 799A66F5F3; Fri, 5 Apr 2019 19:03:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id CU7vhqlFmsAGkCU7whdfqb; Fri, 05 Apr 2019 13:03:50 -0600 X-Authority-Analysis: v=2.3 cv=WeVylHpX c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=oexKYjalfGEA:10 a=pGLkceISAAAA:8 a=zxA2vyXaAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=RiKPiEmj_PkCBvM_GNYA:9 a=qxRNq1ZIBcZtRpE9:21 a=DspgWPCihwn702_f:21 a=CjuIK1q_8ugA:10 a=nK2txNHJmq7TfjpuLlwI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 562D72E6B; Fri, 5 Apr 2019 12:03:46 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x35J3R9a004661; Fri, 5 Apr 2019 12:03:27 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x35J3RHM004658; Fri, 5 Apr 2019 12:03:27 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201904051903.x35J3RHM004658@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Enji Cooper cc: Michael Butler , freebsd-current , phil@freebsd.org Subject: Re: SVN r345859: libxo broke netstat? In-Reply-To: Message from Enji Cooper of "Fri, 05 Apr 2019 09:39:19 -0700." <8A6173F2-B6A5-48E6-9EC0-063698C0C511@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 05 Apr 2019 12:03:27 -0700 X-CMAE-Envelope: MS4wfKCg6yRYIGWkdYYMU8LHBsrSzVwNHmuChKxIbr7Aqy/5y8yOqv9EpgNTnxiAZ8txILY9lrIA3ok/lco7Tn+FpcAAKdFUfbXqunV997/iTz/YzUI0FSea Mcunr4NGM9CF4HpSv0jMaIoL4w3V4Gk91V2rGepZH2uu1zRnAqx/Rvje2RdmV1H1E1k1ny83+boGJ7Kn0JOMHtlMVQOnC15T6Yesz2oOWwxPBxfYjSpjk4Py SaITR1kE8DjuMY6TjHTm8ZA+5xCYIOpBZFRsbSoN1WA+2eBkmTd6CpXOg0gNm/kn X-Rspamd-Queue-Id: 799A66F5F3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.07 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; RCVD_IN_DNSWL_LOW(-0.10)[12.134.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; SUBJECT_ENDS_QUESTION(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.40)[ip: (-6.46), ipnet: 64.59.128.0/20(-3.07), asn: 6327(-2.38), country: CA(-0.09)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 19:03:59 -0000 In message <8A6173F2-B6A5-48E6-9EC0-063698C0C511@gmail.com>, Enji Cooper writes : > > > On Apr 5, 2019, at 5:19 AM, Michael Butler wro > te: > > > > Something changed in libxo that causes 'netstat -i' to segfault as below: > > > > imb@toshi:/usr/src/usr.bin/netstat> lldb > > /usr/obj/usr/src/amd64.amd64/usr.bin/netstat/netstat > > (lldb) target create "/usr/obj/usr/src/amd64.amd64/usr.bin/netstat/netstat" > > Current executable set to > > '/usr/obj/usr/src/amd64.amd64/usr.bin/netstat/netstat' (x86_64). > > (lldb) run -i > > Process 65948 launching > > Process 65948 launched: > > '/usr/obj/usr/src/amd64.amd64/usr.bin/netstat/netstat' (x86_64) > > Name Mtu Network Address Ipkts Ierrs Idrop > > Opkts Oerrs Coll > > Process 65948 stopped > > * thread #1, name = 'netstat', stop reason = signal SIGSEGV: invalid > > address (fault address: 0x0) > > frame #0: 0x00000008002987ad > > libxo.so.0`___lldb_unnamed_symbol30$$libxo.so.0 + 669 > > libxo.so.0`___lldb_unnamed_symbol30$$libxo.so.0: > > -> 0x8002987ad <+669>: movsbl (%r12), %eax > > 0x8002987b2 <+674>: movslq %eax, %rbx > > 0x8002987b5 <+677>: movq 0xac04(%rip), %r13 > > 0x8002987bc <+684>: testl %eax, %eax > > (lldb) bt > > * thread #1, name = 'netstat', stop reason = signal SIGSEGV: invalid > > address (fault address: 0x0) > > * frame #0: 0x00000008002987ad > > libxo.so.0`___lldb_unnamed_symbol30$$libxo.so.0 + 669 > > frame #1: 0x0000000800294e09 > > libxo.so.0`___lldb_unnamed_symbol24$$libxo.so.0 + 1401 > > frame #2: 0x0000000800293b91 > > libxo.so.0`___lldb_unnamed_symbol22$$libxo.so.0 + 609 > > frame #3: 0x0000000800293df0 libxo.so.0`xo_emit + 256 > > frame #4: 0x0000000000212dc5 netstat`intpr + 1669 > > frame #5: 0x0000000000217ecf netstat`main + 2431 > > frame #6: 0x000000000021210f netstat`__fini_array_end + 271 > > Michael, > Could you please file a PR for this? > Thank you! Add arp(8) broken by the libxo import. It's broken at line 603 of libxo.c as well. A NULL pointer deref. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.