From owner-cvs-all Mon Jun 8 22:37:35 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA05448 for cvs-all-outgoing; Mon, 8 Jun 1998 22:37:35 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA05417; Mon, 8 Jun 1998 22:37:18 -0700 (PDT) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id PAA01402; Tue, 9 Jun 1998 15:37:16 +1000 Date: Tue, 9 Jun 1998 15:37:16 +1000 From: Bruce Evans Message-Id: <199806090537.PAA01402@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-bin@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, imp@FreeBSD.ORG Subject: Re: cvs commit: src/bin/cp utils.c src/bin/csh dir.c src/bin/pax ftree.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk >imp 1998/06/08 20:38:44 PDT > > Modified files: > bin/cp utils.c > bin/csh dir.c > bin/pax ftree.c > Log: > Make sure we pass the length - 1 to readlink, since it adds its own > NUL at the end of the path. Actually, readlink() never NUL-terminates, but some buggy applications add their own NUL at the end of the path. Most applications use a buffer of size PATH_MAX, so it's not clear if there are any problems in practice. Does nfs_readlink() actually work for foreign links of size PATH_MAX? Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message