From owner-freebsd-alpha Mon Apr 2 11:35: 9 2001 Delivered-To: freebsd-alpha@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 8B1A037B71D; Mon, 2 Apr 2001 11:34:52 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f32IYcG70901; Mon, 2 Apr 2001 11:34:38 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Mon, 02 Apr 2001 11:34:11 -0800 (PDT) From: John Baldwin To: Doug Rabson Subject: Re: Proposed Loader fix Cc: mjacob@feral.com, freebsd-alpha@FreeBSD.org, Michael Richards , Mike Smith Sender: owner-freebsd-alpha@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 02-Apr-01 Doug Rabson wrote: > On Mon, 2 Apr 2001, Mike Smith wrote: > >> > My proposed solution is: >> > Modify the devsw struct. Here is the original: >> ... >> > This appears to carry info about the device. So I say that I should >> > be able to add a flag to it so it will not be opened multiple times. >> >> Don't do this. Try adding some caching to libalpha so that it doesn't >> open the prom device more than once. Since we only need one handle (SRM >> doesn't support more than one device), once we've got one, we can always >> reuse it. > > How about something like this (untested) patch. I'm not entirely happy > with it since it will never call prom_close and I remember having problems > with ncr hardware not probing properly if we didn't close it in the > loader. Possibly an 'open count' or similar would suffice. It would be better I think since prom_close() would get called eventually. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-alpha" in the body of the message