From owner-freebsd-current@FreeBSD.ORG Thu Mar 27 09:32:37 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 13D019C6; Thu, 27 Mar 2014 09:32:37 +0000 (UTC) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BE94D765; Thu, 27 Mar 2014 09:32:36 +0000 (UTC) Received: from srg.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) by ns.kevlo.org (8.14.8/8.14.8) with ESMTP id s2R9VsXe050618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 27 Mar 2014 17:31:55 +0800 (CST) (envelope-from kevlo@FreeBSD.org) Message-ID: <5333F020.8000200@FreeBSD.org> Date: Thu, 27 Mar 2014 17:32:16 +0800 From: Kevin Lo User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: John Baldwin Subject: Re: UDP Lite support References: <53138FA6.1060705@delphij.net> <532BEC6B.7060400@FreeBSD.org> <201403261122.43541.jhb@freebsd.org> In-Reply-To: <201403261122.43541.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Joe Nosay , freebsd-current@freebsd.org, d@delphij.net, Brooks Davis X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2014 09:32:37 -0000 On 2014/03/26 23:22, John Baldwin wrote: > On Friday, March 21, 2014 3:38:19 am Kevin Lo wrote: >> On 2014/03/03 04:08, Xin Li wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA512 >>> >>> On 3/2/14, 10:42 AM, Joe Nosay wrote: >>>> On Thu, Feb 27, 2014 at 3:22 AM, Joe Nosay >>>> wrote: >>>> >>>>> >>>>> On Wed, Feb 26, 2014 at 11:19 PM, Xin Li >>>>> wrote: >>>>> >>>> On 02/26/14 18:52, Joe Nosay wrote: >>>>>>>> On Wed, Feb 26, 2014 at 9:19 PM, Brooks Davis >>>>>>>> wrote: >>>>>>>> >>>>>>>>> On Wed, Feb 26, 2014 at 07:36:29PM -0500, Joe Nosay >>>>>>>>> wrote: >>>>>>>>>> The last thread on this was in 2006. Has it ever been >>>>>>>>>> reconsidered or is the likelihood of too many damaged >>>>>>>>>> packets the reason for not supporting? I'm not sure >>>>>>>>>> where to put this question. Apologies for the noise. >>>>>>>>> You've provided next to no context. What is the >>>>>>>>> question? What thread are you referring to? If this is >>>>>>>>> the usual UDP then freebsd-net would be vastly more >>>>>>>>> appropriate than -current. >>>>>>>>> >>>>>>>>> -- Brooks >>>>>>>>> >>>>>>>> Thanks. I will ask kevlo and maybe bring it up on >>>>>>>> freebsd-net. It has to do with an implementation of the >>>>>>>> JACK server using UDP Lite for transferring data. >>>>>>>> >>>>>>>> >>>> http://freebsd.1045724.n5.nabble.com/UDP-lite-for-FreeBSD-td4010236.html >>>> >>>> Looks >>>> like nobody proposed a patch? >>>> >>>> I think the concern was that this is not very useful in real-world >>>> scenarios due to link layer error detection mechanism but that >>>> doesn't raise a red flag to me assuming this is sufficiently self >>>> contained feature as it would improve compatibility with other >>>> operating systems. >>>> >>>> Cheers, >>>>> https://github.com/torelizer/jack_trauma >>>>> >>>>> Not my project; but, I want to port it to FreeBSD. First is to >>>>> get it to build from source. Use your raspberry pi with FreeBSD >>>>> to broadcast your tunes and all. >>>>> >>>> Thanks for all of the input. The project is being reworked to >>>> improve the code. >>> Kevin Lo have a patchset but needs someone to do performance testing >>> (its impact on non-UDPLite applications), test with vimage, etc: >>> >>> http://people.freebsd.org/~kevlo/udplite.diff >>> http://people.freebsd.org/~kevlo/udp-v.diff >>> >>> Are you interested in working on these and report back? >> The revised patch is available at: >> http://people.freebsd.org/~kevlo/udplite.diff Thank you for your suggestions. > A few suggestions: > > - I would just drop the INP lock and return EOPNOTSUPP directly rather > than using goto's to 'bad_setoptname' and 'bad_getoptname' so the > UDP-lite options are self-contained. Fixed. > - I'm not a super big fan of all the udp_common_* macros only because > I think it obfuscates things. At the very least, please move these > things out of the header and into udp_usrreq.c so they are closer > to the implementation. I would even suggest making them inline > functions instead of macros. Okay, I removed two udp_common_* macros. I also renamed udp_common_init() to udp_udplite_init() and moved it into udp_usrreq.c. Using a macro here to follow the style used in SCTP (sctp_os_bsd.h). Here's a third version of the udp-lite patch: http://people.freebsd.org/~kevlo/udplite.diff > > However, I think the patch generally looks ok. Cool! Thanks again for your review of udp-lite's patch :-) Kevin