From owner-freebsd-current@FreeBSD.ORG Tue Aug 21 11:35:12 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8651E16A419; Tue, 21 Aug 2007 11:35:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 30A7113C46A; Tue, 21 Aug 2007 11:35:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=deviant.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1INS0q-00047u-OC; Tue, 21 Aug 2007 14:35:11 +0300 Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id l7LBZ5k7036031; Tue, 21 Aug 2007 14:35:05 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.1/8.14.1/Submit) id l7LBZ4nH036030; Tue, 21 Aug 2007 14:35:04 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 21 Aug 2007 14:35:04 +0300 From: Kostik Belousov To: Kris Kennaway Message-ID: <20070821113504.GA2738@deviant.kiev.zoral.com.ua> References: <200708202340.29678.qpadla@gmail.com> <20070820205201.GW2738@deviant.kiev.zoral.com.ua> <20070821045739.GA83774@rot26.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZkFfH+RuFRkNoGBj" Content-Disposition: inline In-Reply-To: <20070821045739.GA83774@rot26.obsecurity.org> User-Agent: Mutt/1.4.2.3i X-Scanner-Signature: 7ffaa6bc246e67c9b1a22e0c753f4a43 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 1391 [August 20 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: freebsd-current@freebsd.org, rwatson@freebsd.org Subject: Re: And probably the final crash for today's current :) (panic: filesystem goof: vop_panic[vop_print]) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2007 11:35:12 -0000 --ZkFfH+RuFRkNoGBj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 21, 2007 at 12:57:40AM -0400, Kris Kennaway wrote: > On Mon, Aug 20, 2007 at 11:52:01PM +0300, Kostik Belousov wrote: >=20 > > Quite often, the "impossible" panics with vnode locking are happens > > because some other thread already paniced the kernel. Then, lockmgr > > passes all lock requests without actually locking. I would suggest > > looking around to make sure this is not the case there. >=20 > Is there a good reason to be doing that? Hmm. This is revision 1.47 of sys/kern/kern_lock.c: date: 2001/08/10 23:29:15; author: jhb; state: Exp; lines: +6 -1 If we've panic'd already, then just bail in lockmgr rather than blocking or possibly panic'ing again. --ZkFfH+RuFRkNoGBj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGys3oC3+MBN1Mb4gRArAqAJ9w/FQO+olZbKzDCAXJqcksJWglpgCcCyHd GpmncZJbSn6bNciIUBrK5LU= =oExS -----END PGP SIGNATURE----- --ZkFfH+RuFRkNoGBj--