From owner-freebsd-current@FreeBSD.ORG  Thu Feb  5 02:02:51 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1316716A4CE
	for <current@freebsd.org>; Thu,  5 Feb 2004 02:02:51 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9B39643D1F
	for <current@freebsd.org>; Thu,  5 Feb 2004 02:02:49 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id i15A2lDF039983
	for <current@freebsd.org>; Thu, 5 Feb 2004 11:02:47 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: current@freebsd.org
From: Poul-Henning Kamp <phk@phk.freebsd.dk>
Date: Thu, 05 Feb 2004 11:02:47 +0100
Message-ID: <39982.1075975367@critter.freebsd.dk>
Subject: HEADSUP:  disk_*(9) API change mega-patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Feb 2004 10:02:51 -0000


This is a mostly mechanical and largely untested patch, so please test
carefully if you have the necessary hardware.

Kernel patch:
	http://phk.freebsd.dk/patch/disk.patch

Man-page update:
	http://phk.freebsd.dk/patch/disk_man.patch

Patch version: 2004-02-05.1

This patch changes the disk_*(9) API so that ownership of the "struct
disk" is moved from the device drivers to GEOM.  This removes a lot
of trouble from the disk_destroy(9) handling, which should be robust
with this patch.

After this change the API works as follows:

	allocated struct disk with disk_alloc(), store pointer in softc.
	populate fields, including d_unit and d_flags which were
	previous arguments to disk_create().
	call disk_create() with the pointer.

	call disk_destroy() to signal that the device has disappeared.
	NB: do not access struct disk in the driver anymore!
	return any outstanding requests with suitable error.

At the same time: eliminate unused arguments from disk_create(9)

Reverse sense of DISKFLAG_NOGIANT, to DISKFLAG_NEEDSGIANT.

Two weeks review

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.