Date: Wed, 10 Mar 1999 22:00:01 -0800 (PST) From: Cy Schubert - ITSD Open Systems Group <Cy.Schubert@uumail.gov.bc.ca> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/10528: MFS fails to die when system shut down Message-ID: <199903110600.WAA28228@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/10528; it has been noted by GNATS. From: Cy Schubert - ITSD Open Systems Group <Cy.Schubert@uumail.gov.bc.ca> To: freebsd-gnats-submit@freebsd.org Cc: cschuber@uumail.gov.bc.ca, dillon@freebsd.org Subject: Re: kern/10528: MFS fails to die when system shut down Date: Wed, 10 Mar 1999 21:51:47 -0800 Matthew, I've been trying to solve a "syncing filesystems... giving up" problem under 3.1. My first cut was effective under some circumstances, e.g. copying files to MFS but if MFS was used for /tmp and X was in use at the time of the shutdown, my patch would still fail. I've devised a better patch as follows. What do you think? What I've done is change the P_SYSTEM flag to a P_NOSWAP. What I don't understand is the comment about the swapper continuously trying to kill MFS. I can see why you don't want it to swap out, because of potential deadlock. It solves a "syncing filesystems" problem during shutdown. I tested during a shutdown while a file is currently being written to /tmp. Previously the system would panic: vinvalbuf: dirty bufs. With the patch below it doesn't do that any more. Does my patch introduce another problem? I'd appreciate some guidance. --- src/sys/ufs/mfs/mfs_vfsops.c.orig Thu Dec 31 20:14:11 1998 +++ src/sys/ufs/mfs/mfs_vfsops.c Wed Mar 10 21:08:13 1999 @@ -399,7 +399,8 @@ * can we swap out this process - not unless you want a deadlock, * anyway. */ - curproc->p_flag |= P_SYSTEM; + /* curproc->p_flag |= P_SYSTEM; */ + curproc->p_flag |= P_NOSWAP; while (mfsp->mfs_active) { while (bp = bufq_first(&mfsp->buf_queue)) { Regards, Phone: (250)387-8437 Cy Schubert Fax: (250)387-5766 Open Systems Group Internet: Cy.Schubert@uumail.gov.bc.ca ITSD Cy.Schubert@gems8.gov.bc.ca Province of BC To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199903110600.WAA28228>