From owner-freebsd-hackers@FreeBSD.ORG  Fri Mar  2 22:31:40 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0D098106566B
	for <hackers@freebsd.org>; Fri,  2 Mar 2012 22:31:40 +0000 (UTC)
	(envelope-from ambrisko@ambrisko.com)
Received: from mail.ambrisko.com (mail.ambrisko.com [70.91.206.90])
	by mx1.freebsd.org (Postfix) with ESMTP id DC5428FC0A
	for <hackers@freebsd.org>; Fri,  2 Mar 2012 22:31:39 +0000 (UTC)
X-Ambrisko-Me: Yes
Received: from server2.ambrisko.com (HELO internal.ambrisko.com)
	([192.168.1.2])
	by ironport.ambrisko.com with ESMTP; 02 Mar 2012 14:03:05 -0800
Received: from ambrisko.com (localhost [127.0.0.1])
	by internal.ambrisko.com (8.14.4/8.14.4) with ESMTP id q22M30L7071372; 
	Fri, 2 Mar 2012 14:03:00 -0800 (PST)
	(envelope-from ambrisko@ambrisko.com)
Received: (from ambrisko@localhost)
	by ambrisko.com (8.14.4/8.14.4/Submit) id q22M30eI071370;
	Fri, 2 Mar 2012 14:03:00 -0800 (PST) (envelope-from ambrisko)
From: Doug Ambrisko <ambrisko@ambrisko.com>
Message-Id: <201203022203.q22M30eI071370@ambrisko.com>
In-Reply-To: <1330720724.5391.2.camel@powernoodle-l7.corp.yahoo.com>
To: sbruno@freebsd.org
Date: Fri, 2 Mar 2012 14:03:00 -0800 (PST)
X-Mailer: ELM [version 2.4ME+ PL124d (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"
Cc: hackers@freebsd.org
Subject: Re: [patch] Disable bios probe if acpi is enabled
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2012 22:31:40 -0000

Sean Bruno writes:
| I'm noting that newer machines are completely hosed if we attempt to
| probe for bios values.  I'm proposing this change.
| 
| -bash-4.2$ p4 diff -du //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c
| --- //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c       2011-09-16
| 22:47:30.000000000 0000
| +++ /home/seanbru/ybsd_7/src/sys/i386/i386/bios.c       2011-09-16
| 22:47:30.000000000 0000
| @@ -84,6 +84,12 @@
|      char                       *p;
|      
|      /*
| +     * Don't do bios probing if acpi is enabled, its
| +     * pointless and breaks on newer systems
| +     */
| +    if (!resource_disabled("acpi", 0))
| +       return;
| +    /*
|       * BIOS32 Service Directory, PCI BIOS
|       */
| 

That seems reasonable to me.

Doug A.