From owner-cvs-all Sun Jun 30 23: 8:35 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E77837B400; Sun, 30 Jun 2002 23:08:26 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id ED8F043E09; Sun, 30 Jun 2002 23:08:24 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA18951; Mon, 1 Jul 2002 16:08:14 +1000 Date: Mon, 1 Jul 2002 16:13:58 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Andrew Gallatin Cc: Luigi Rizzo , , Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 In-Reply-To: <20020630154951.A20313@grasshopper.cs.duke.edu> Message-ID: <20020701160159.C6692-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 30 Jun 2002, Andrew Gallatin wrote: > Luigi Rizzo [luigi@FreeBSD.org] wrote: > > luigi 2002/06/30 00:56:49 PDT > > > > Modified files: (Branch: RELENG_4) > > sys/i386/isa clock.c > > sys/i386/include param.h > > sys/conf options.i386 > > Log: > > Add one function and one macro to timestamp events in the kernel using > > the TSC register and which are just too conveninent not to have them around. > > > > The macro (defined in sys/i386/include/param.h) is called > > > > TSTMP(class:4, unit:4, event:8, par:16) > > Before adding the TSTMP macro to any MI code, please remember to > either implement it on alpha in terms of alpha_rpcc() or to at least > add a stub to alpha/include/param.h so that you don't break kernel > builds on alpha. Before adding it anywhere, please implement in a correct place. It has no parameters in it; param.h is just being used because pollution in it is visible everywhere. I previously objected to this idea (of a generic lightweight trace facility) for similar reasons to phk -- it's very hard to make it even two of generic, lightweight and useful. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message