Date: Mon, 1 Jul 2002 16:13:58 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Andrew Gallatin <gallatin@cs.duke.edu> Cc: Luigi Rizzo <luigi@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 Message-ID: <20020701160159.C6692-100000@gamplex.bde.org> In-Reply-To: <20020630154951.A20313@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 30 Jun 2002, Andrew Gallatin wrote: > Luigi Rizzo [luigi@FreeBSD.org] wrote: > > luigi 2002/06/30 00:56:49 PDT > > > > Modified files: (Branch: RELENG_4) > > sys/i386/isa clock.c > > sys/i386/include param.h > > sys/conf options.i386 > > Log: > > Add one function and one macro to timestamp events in the kernel using > > the TSC register and which are just too conveninent not to have them around. > > > > The macro (defined in sys/i386/include/param.h) is called > > > > TSTMP(class:4, unit:4, event:8, par:16) > > Before adding the TSTMP macro to any MI code, please remember to > either implement it on alpha in terms of alpha_rpcc() or to at least > add a stub to alpha/include/param.h so that you don't break kernel > builds on alpha. Before adding it anywhere, please implement in a correct place. It has no parameters in it; param.h is just being used because pollution in it is visible everywhere. I previously objected to this idea (of a generic lightweight trace facility) for similar reasons to phk -- it's very hard to make it even two of generic, lightweight and useful. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020701160159.C6692-100000>