Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 30 Sep 2021 20:50:10 +0200
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64*
Message-ID:  <YVYG4ocHKoBWgEgN@KGPE-D16>
In-Reply-To: <5yuh-c3nk-wny@FreeBSD.org>
References:  <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> <5yuh-c3nk-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--gOLrRZmXIpyQb2hJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21-09-30 20:35:43, Jan Beich wrote:
> Piotr Kubaj <pkubaj@FreeBSD.org> writes:
>=20
> > The branch main has been updated by pkubaj:
> >
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dfc75da3a3b2adf1148010f=
e1f3cd75528387bdcc
> >
> > commit fc75da3a3b2adf1148010fe1f3cd75528387bdcc
> > Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > AuthorDate: 2021-09-30 15:48:31 +0000
> > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2021-09-30 15:48:31 +0000
> >
> >     graphics/libjxl: fix build on powerpc64*
> >    =20
> >     Add FreeBSD variants for linux code.
> >    =20
> >     The include in cpu.cc is not actually necessary, so I did not inclu=
de anything for FreeBSD.
>=20
> Can you submit the fix upstream or replace downstream (the port) fix
> with upstream one?
>=20
> See https://github.com/google/highway/commit/3769cb2c464c
Ok, I will later.
>=20
> > ++#if linux
>=20
> Why not __linux__ (with underscores)?
linux is also correct:
pkubajx@pkubajx-mobl1:~$ echo | cc -dM -E - | grep linux
#define __linux 1
#define __gnu_linux__ 1
#define linux 1
#define __linux__ 1

--gOLrRZmXIpyQb2hJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFWBuIACgkQelmbhSCD
nJ0puA/+MA38TVlE/W95FhX6dvKyvqLqRJVNGMr+6D82yQANyRMwTYqflU2lhmSb
QRaTu/kJge8+bnxTX5mjwqxp3A4/8uXzpWK3seodUtNPAqSXk8cLxo2uf7p9CGw0
HPc/UglgZny5r9YlFy/UJgdQ1LoNU9onXxxsLvHHk+6i7FX0Ai3T373bzSC/SyW/
sTT5Y3A3QfAHzR145X5BGpEO2a9wcqvN+e1ZNMbY1t4mvfWZE5kAqTaaCKh1Z1Xc
Q7K0OJop78KybuVx2ZAoSLrWOscPlRH1y+iMPsqHUUqHHnWL71219Kr5dw+AgsrW
YLuOv+KuQMW3GAuKcZqFhDwUZe+SL6zzXq2Yj1R9pBU9puZbb2XvqxET4N3MhPXG
4zaPsTdMfaqFnUXfADY7P5i2LVKiBkgqZEf4QO5rdVOGD2OpKmTw2nlqOmPnvcHv
6B+6V7TZrUsieopgwM2F+uDSvZQJ6BoGwlnbYV94LTHS/FnFvdVg+QJko2VuFXjw
Z6Z4fAW5I1iZouWM+a8kuZe6cc1WgavVTZ/NkS5YM99xNm0IRJ/NG7YyZoLeSDry
9K/Kd/DfUimlB9HNbdkgSIUPm0/JBOwR4abnzarD/1TSTOYCk/0FX/mF0DwlOVYe
QdLmaGEqXLlzjgJJExeYpspnS7fFG4meJPLKZuqDMpInNLxA9FU=
=0ZgU
-----END PGP SIGNATURE-----

--gOLrRZmXIpyQb2hJ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVYG4ocHKoBWgEgN>