From owner-freebsd-ports@freebsd.org Tue Apr 7 16:20:35 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C94227406E for ; Tue, 7 Apr 2020 16:20:35 +0000 (UTC) (envelope-from "") Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48xXh2043jz3NgH for ; Tue, 7 Apr 2020 16:20:33 +0000 (UTC) (envelope-from "") Received: by mail-qv1-xf2a.google.com with SMTP id v38so2099235qvf.6 for ; Tue, 07 Apr 2020 09:20:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version; bh=k3g5mZkp87IV9ngtv0wSlhvOP/khdIU3re1WkP1r6EM=; b=togEPzHIT/7b8Q81h4S2E0Jl8v2DtxINzcvF/7RO3afPZzfRq7cKJpGYeQpDIbKXb+ MXFsrGsOqCTo0apaxpJB9mVHkE0uIHAg+z24i98PzeICzOaUtuci13lPGlHO1lT4TIYO oxsIdlcgeZlATmE0DSbBB+Tak83bpOjsgLIAGcu7Ki6fQVLenX7yp+3bmwLXbgnEBllz Y6TJ0JJw8OrSt7WP9tIiJ8Le8sBofwOOYEQovE2y9sXugaPzTwY+PNq9VR3T6bmzY8cD ViSFQzQ2++snYegzekxISnq+HLJ8YPhPg85KkcKi8tuWj3BCNBbhuD2fTJzOIMaB7i6c d8Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version; bh=k3g5mZkp87IV9ngtv0wSlhvOP/khdIU3re1WkP1r6EM=; b=d/whzzBoMTJ2cWl8GNvXhDGUOvcE4yNffUVBf02rMaMiuqLo7ZsL5NoUfMF2nXj/zR m6CYx3GZLnxRh0fSK1IgKFxlj7vI2QKfvTW6mzB88iFz04kPmEXrZElb/Ng5/mIrwAxB 09wNVFtgnpZdcF9k28J2GFM1Mmhf709WrDX9hTOOnczJzBs7fa6fciFKS80WFWTOKrAM c7Re2EaITsYUDFGQbquGD//vR2S7PRqpiQdjV/8Zjh3ArYTW/i4I42zfRbK4BsNZ0EM0 2xp4OI0yeC8WAKp7OZ58l/UjaINapa78OZR5NncnxJvG+nwG6mo51XcXmCCmeF9akNx+ WOhA== X-Gm-Message-State: AGi0PuYGOg8yaAE+bHqHGZvU4y51O7SYaO9SrhTOOdVTvtiIJnw+aGys 9fjnrJjV40x3PmFDuG/a+vzKUeopNIk= X-Google-Smtp-Source: APiQypKNycJqdU3BwdFte9+50O8tThC9KY3BxxAwfzS8YWyRiydMFI11kPpY+AuQE+xBcHjorJsERA== X-Received: by 2002:a0c:f84f:: with SMTP id g15mr2911370qvo.174.1586276432816; Tue, 07 Apr 2020 09:20:32 -0700 (PDT) Received: from heimdall.localnet (host-104-171-251-147.BROOLT4.epbfi.com. [104.171.251.147]) by smtp.gmail.com with ESMTPSA id f68sm16837049qtb.19.2020.04.07.09.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2020 09:20:26 -0700 (PDT) From: Adam Jimerson To: Adam Weinberger Cc: freebsd-ports@freebsd.org Subject: Re: Running tests in ports Makefiles? Date: Tue, 07 Apr 2020 12:20:25 -0400 Message-ID: <4798344.YNO7O01DYZ@heimdall> In-Reply-To: References: <2970225.0P3pStmDMi@heimdall> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3025142.bT80LyP3VS"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Rspamd-Queue-Id: 48xXh2043jz3NgH X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=togEPzHI; dmarc=pass (policy=none) header.from=gmail.com; spf=none (mx1.freebsd.org: domain of mail-qv1-xf2a.google.com has no SPF policy when checking 2607:f8b0:4864:20::f2a) smtp.helo=mail-qv1-xf2a.google.com X-Spamd-Result: default: False [-3.40 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; SIGNED_PGP(-2.00)[]; IP_SCORE(0.00)[ip: (-6.15), ipnet: 2607:f8b0::/32(-0.33), asn: 15169(-0.43), country: US(-0.05)]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[vendion@gmail.com,]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[a.2.f.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2020 16:20:35 -0000 --nextPart3025142.bT80LyP3VS Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Tuesday, April 7, 2020 11:35:38 AM EDT Adam Weinberger wrote: > Optional tests should never be run during a normal build. There is a > "do-test:" target for that purpose. Can you fold the test suite into > that target? Yeah it would be completely possible to use that target for the tests, and thanks for pointing that out as I don't see it listed under Section 5.13.3.12 of the Porter's Handbook [0]. I just didn't know if this was common place to do so with FreeBSD ports. The only thing I have to compare it with is Arch Linux's build system where if a packages PKGBUILD file defines a `check` function [1] then it is called during the build process automatically. I know comparing apples to oranges, hence why I wanted to know what is commonplace/acceptable here. [0]: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ makefile-options.html [1]: https://wiki.archlinux.org/index.php/Creating_packages#check() --nextPart3025142.bT80LyP3VS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEELLlB4D3dJQL6YIqWtmZSyNpTGkkFAl6MqDYACgkQtmZSyNpT GkkE8Qf+JOg7eD2+Y/O090U0C2C3c9VOWtesUh7Il6GI3+VN5bKJIRvvjN3+bENO qm1gHFnQGKPO5oZxUgKsOW6OJk9NGDMp/oFiqcnJVAstO/5nBX6iAQt0AEy2i8y9 C6SUsKIn+heNMKh+nUh6u7mUPoARH71rJ0tT8VxbsBwygb6h7S7Sn7H6ojKt+BXA vdahF5He0+B5svcKch0RGvJxFi6tH3z6t7RdP16ty8yUXyh83bplajN2Chrcw6oh b37IuZ1bYLzuDABZgveAMWhslsyMvBs2fIrPrFHfwonf5xJNygb3F1JoTW98lpK2 QpMm9BgweliWz4vsRIKSupJmOfnWQQ== =+mtM -----END PGP SIGNATURE----- --nextPart3025142.bT80LyP3VS--