From owner-freebsd-current@FreeBSD.ORG Tue Oct 14 06:09:56 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67F0016A4B3 for ; Tue, 14 Oct 2003 06:09:56 -0700 (PDT) Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 531EC43F3F for ; Tue, 14 Oct 2003 06:09:54 -0700 (PDT) (envelope-from sos@spider.deepcore.dk) Received: from spider.deepcore.dk (localhost [127.0.0.1]) by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id h9ED9xXu001776; Tue, 14 Oct 2003 15:09:59 +0200 (CEST) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.10/8.12.10/Submit) id h9ED9wxc001775; Tue, 14 Oct 2003 15:09:59 +0200 (CEST) (envelope-from sos) From: Soren Schmidt Message-Id: <200310141309.h9ED9wxc001775@spider.deepcore.dk> In-Reply-To: <1066136658.2588.14.camel@kaiser.sig11.org> To: Matteo Riondato Date: Tue, 14 Oct 2003 15:09:58 +0200 (CEST) X-Mailer: ELM [version 2.4ME+ PL99f (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 X-mail-scanned: by DeepCore Virus & Spam killer v1.3 cc: current@FreeBSD.ORG Subject: Re: ata problem with 13/10/2003 current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2003 13:09:56 -0000 It seems Matteo Riondato wrote: > After having update my -CURRENT box to yesterday afternoon (Central > Europe Time) sources, I can't get it to boot. It stops probing ata1: > GEOM: create disk ad0 dp=0xc4536a70 > ad0: 57259MB [116336/16/63] at ata0-master UDMA133 > GEOM: create disk ad1 dp=0xc4915a70 > ad1: 38172MB [77557/16/63] at ata0-slave \ > UDMA100 > ata1: resetting devices .. > acd0: FAILURE - SETFEATURES status=51 error=4 > done > acd0: FAILURE - SETFEATURES device lockup-removed > > And it stops here. > > On ata1 there are a Liteon CD-ReWriter 48x12x48x (acd0) > and a LG DVD-ROM Drive DRD-8160B (acd1) > > I never had problem with ATAng before, so it is probably related to a > recent commit. Could you try this patch please: Index: ata-queue.c =================================================================== RCS file: /home/ncvs/src/sys/dev/ata/ata-queue.c,v retrieving revision 1.8 diff -u -r1.8 ata-queue.c --- ata-queue.c 12 Oct 2003 12:38:03 -0000 1.8 +++ ata-queue.c 13 Oct 2003 13:05:01 -0000 @@ -315,20 +315,21 @@ static void ata_timeout(struct ata_request *request) { + struct ata_channel *ch = request->device->channel; + int quiet = request->flags & ATA_R_QUIET; + /* clear timeout etc */ request->timeout_handle.callout = NULL; -#if 0 - /* call interrupt to try finish up the command */ - request->device->channel->hw.interrupt(request->device->channel); - if (request->device->channel->running == NULL) { - if (!(request->flags & ATA_R_QUIET)) + /* call hw.interrupt to try finish up the command */ + ch->hw.interrupt(request->device->channel); + if (ch->running != request) { + if (!quiet) ata_prtdev(request->device, "WARNING - %s recovered from missing interrupt\n", ata_cmd2str(request)); return; } -#endif /* if this was a DMA request stop the engine to be on the safe side */ if (request->flags & ATA_R_DMA) { -Søren