From owner-freebsd-amd64@FreeBSD.ORG Mon Apr 20 21:25:31 2015 Return-Path: Delivered-To: amd64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA8A321C; Mon, 20 Apr 2015 21:25:31 +0000 (UTC) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7698D662; Mon, 20 Apr 2015 21:25:31 +0000 (UTC) Received: by wiun10 with SMTP id n10so107234242wiu.1; Mon, 20 Apr 2015 14:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=G5NBfn+u03Zdf81gPvgH17MBIThAdSC9cgGtECLYaeQ=; b=l11sTyXhlRj2sSHwEYcCnrOkpLNuK2JiyFKuKwrRP4EpbGhHkUhnJfBDKNrESD+lr1 CjN/Czj0QNCOadQlr60G96AcvHGH67r1oIr7FsRSttyiFSWerpx2BF3YLxRWUVioF1rq RLIExQuBO861sh9X+m9i9J4QEv0G+Uz0/uq2Dl8ft/GtERsf3cTjwJxqIN8/wMa2p7nI Y/QASXSCpYJbwE0so1g4SmExwx606fnE66iQbmgBK5W2YlWV4jGMyFh+Tyl+WEwQt/A/ 7Y4NW+v3sKYUUZjDbeAr7/nSC0nGwiugl8fuMUYhazHp6oHxluWk81O2zSv+2rUqGeUd PaxA== MIME-Version: 1.0 X-Received: by 10.180.104.137 with SMTP id ge9mr29625940wib.24.1429565129111; Mon, 20 Apr 2015 14:25:29 -0700 (PDT) Received: by 10.27.80.202 with HTTP; Mon, 20 Apr 2015 14:25:29 -0700 (PDT) In-Reply-To: <20150420162149.GE2390@kib.kiev.ua> References: <20150420162149.GE2390@kib.kiev.ua> Date: Tue, 21 Apr 2015 00:25:29 +0300 Message-ID: Subject: Re: Move x86 idle code to the x86/ common place. From: Sergey Kandaurov To: Konstantin Belousov Cc: arch@freebsd.org, amd64@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 21:25:32 -0000 On 20 April 2015 at 19:21, Konstantin Belousov wrote: [..] > +struct { > + void *id_fn; > + char *id_name; > +} idle_tbl[] = { > + { cpu_idle_spin, "spin" }, > + { cpu_idle_mwait, "mwait" }, > + { cpu_idle_hlt, "hlt" }, > +#if !defined(__i386__) || !defined(PC98) > + { cpu_idle_acpi, "acpi" }, > +#endif > + { NULL, NULL } > +}; > + I believe this conditional could be left unchanged as #ifndef PC98 (also in several other places), given that pc98 may not be present other than under i386. Otherwise, looks good. -- wbr, pluknet