From owner-freebsd-acpi@FreeBSD.ORG Tue Oct 19 12:52:56 2010 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBBA0106566B; Tue, 19 Oct 2010 12:52:56 +0000 (UTC) (envelope-from decke@FreeBSD.org) Received: from mail.itac.at (mail.itac.at [91.205.172.9]) by mx1.freebsd.org (Postfix) with ESMTP id 541698FC13; Tue, 19 Oct 2010 12:52:56 +0000 (UTC) Received: from [91.205.172.21] (helo=secure.bluelife.at) by mail.itac.at with esmtpa (Exim 4.63) (envelope-from ) id 1P8BgU-0001Vu-Pf; Tue, 19 Oct 2010 14:52:55 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Date: Tue, 19 Oct 2010 12:52:56 +0000 From: Bernhard Froehlich To: Jung-uk Kim In-Reply-To: <201010181333.29143.jkim@FreeBSD.org> References: <201010181333.29143.jkim@FreeBSD.org> Message-ID: <08905cd48f28787b5b3d36a4e75fb793@bluelife.at> X-Sender: decke@FreeBSD.org User-Agent: Roundcube Webmail/0.4 X-Spam-Score: -1.1 (-) X-Spam-Report: Spam detection software, running on the system "mail.itac.at", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 18 Oct 2010 13:33:26 -0400, Jung-uk Kim wrote: > On Monday 18 October 2010 05:44 am, Bernhard Froehlich wrote: >> Hi guys! >> >> VirtualBox has a compile problem with latest acpica. I've talked to >> the VirtualBox developers and they think it's an acpica problem >> which should be fixed upstream. Can we somehow file a bugreport or >> create a patch to fix that in acpica? > > Excerpt rom ACPI 4.0a: > > > Each Compatible Device ID must be either: > > o A valid HID value (a 32-bit compressed EISA type ID or a string such > as "ACPI0004"). > o A string that uses a bus-specific nomenclature. For example, _CID > can be used to specify the PCI ID. > > > Since it is not a valid HID value, you can only say it may be a > bus-specific nomenclature at best. However, it looks like an ISA > device to me and probably it is just a bogus ID. In fact, I googled > a bit and it only exists on some Intel Mac models, it seems. You can > just remove the entire _CID unless it is absolutely necessary, which > is very unlikely. :-) [...] Content analysis details: (-1.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.4 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.3 AWL AWL: From: address is in the auto white-list Cc: freebsd-acpi@FreeBSD.org, vbox@freebsd.org Subject: Re: VirtualBox: Compile problems with ACPICA 20101013 X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 12:52:56 -0000 On Mon, 18 Oct 2010 13:33:26 -0400, Jung-uk Kim wrote: > On Monday 18 October 2010 05:44 am, Bernhard Froehlich wrote: >> Hi guys! >> >> VirtualBox has a compile problem with latest acpica. I've talked to >> the VirtualBox developers and they think it's an acpica problem >> which should be fixed upstream. Can we somehow file a bugreport or >> create a patch to fix that in acpica? > > Excerpt rom ACPI 4.0a: > > --------------------------------------------------- > Each Compatible Device ID must be either: > > o A valid HID value (a 32-bit compressed EISA type ID or a string such > as "ACPI0004"). > o A string that uses a bus-specific nomenclature. For example, _CID > can be used to specify the PCI ID. > --------------------------------------------------- > > Since it is not a valid HID value, you can only say it may be a > bus-specific nomenclature at best. However, it looks like an ISA > device to me and probably it is just a bogus ID. In fact, I googled > a bit and it only exists on some Intel Mac models, it seems. You can > just remove the entire _CID unless it is absolutely necessary, which > is very unlikely. :-) It very much looks like a regression. Right beyond that sentences they have a few examples in the ACPI 4.0a spec on page 201 that won't pass that check. I haven't looked at all the code so probably it's done somewhere completely different but if it is checked with that code then it will complain. ACPI 4.0a spec on page 201: --------------------------------------------------- o A valid HID value (a 32-bit compressed EISA type ID or a string such as "ACPI0004"). o A string that uses a bus-specific nomenclature. For example, _CID can be used to specify the PCI ID. "PCI\CC_ccss" "PCI\CC_ccsspp" "PCI\VEN_vvvv&DEV_dddd&SUBSYS_ssssssss&REV_rr" .... --------------------------------------------------- Now with a deeper look at the commit from acpica [1] especially the second half. Before there was only an alphanumeric check for _HID but with that change it was put into a new function AnCheckId() that is called for both _HID and _CID and now wants both to be alphanumeric. That looks correct for _HID but it's too strict for _CID which is a string. Somewhere i've seen string is defined as a null-terminated ASCII string and no word about alphanumeric. [1] http://git.moblin.org/cgit.cgi/acpica/commit/?id=b66fd716e0b9b5389e >> Compile error: >> kBuild: iasl DevicesR3 - >> /usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.10_OSE/src/ >>VBox/Devices/PC/vbox.dsl >> /usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.10_OSE/src/ >>VBox/Devices/PC/vbox.dsl 736: Name (_CID, >> "smc-napa") >> Error 4001 - >> String must be entirely >> alphanumeric ^ (smc-napa) >> >> ASL Input: >> /usr/ports/emulators/virtualbox-ose/work/VirtualBox-3.2.10_OSE/src/ >>VBox/Devices/PC/vbox.dsl - 1305 lines, 46193 bytes, 288 keywords >> Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 404 >> Optimizations >> >> >> I have found the commit that introduces this additional checks: >> http://git.moblin.org/cgit.cgi/acpica/commit/?id=b66fd716e0b9b5389e >>544c58df189c817f316c3b >> >> and here is the dsl file from virtualbox: >> http://www.virtualbox.org/browser/trunk/src/VBox/Devices/PC/vbox.ds >>l#L781 >> >> >> Thanks! -- Bernhard Froehlich http://www.bluelife.at/