From owner-cvs-all Sun Jun 30 23: 9: 4 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 873D737B400; Sun, 30 Jun 2002 23:08:57 -0700 (PDT) Received: from patrocles.silby.com (d119.as15.nwbl0.wi.voyager.net [169.207.134.247]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9EE343E0A; Sun, 30 Jun 2002 23:08:55 -0700 (PDT) (envelope-from silby@silby.com) Received: from patrocles.silby.com (localhost [127.0.0.1]) by patrocles.silby.com (8.12.4/8.12.4) with ESMTP id g616Bicv083900; Mon, 1 Jul 2002 01:11:44 -0500 (CDT) (envelope-from silby@silby.com) Received: from localhost (silby@localhost) by patrocles.silby.com (8.12.4/8.12.4/Submit) with ESMTP id g616Bfkn083897; Mon, 1 Jul 2002 01:11:43 -0500 (CDT) X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs Date: Mon, 1 Jul 2002 01:11:41 -0500 (CDT) From: Mike Silbersack To: Luigi Rizzo Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c In-Reply-To: <200206302228.g5UMS0kk053262@freefall.freebsd.org> Message-ID: <20020701010949.Y83840-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 30 Jun 2002, Luigi Rizzo wrote: > luigi 2002/06/30 15:28:00 PDT > > Modified files: > sys/dev/fxp if_fxp.c > Log: > Fix if_timer logic so that there is always a timeout pending if there > are packets queued for transmission. > > This driver is strange -- it never sets IFF_OACTIVE, so all > transmissions always cause a call to fxp_start. However, if the > link gets stuck, there was nothing to reset it, so there was still > a possibility of lockups. > > MFC after: 3 days > > Revision Changes Path > 1.132 +4 -2 src/sys/dev/fxp/if_fxp.c Do you know what's ironic about this? The day after you posted your question asking about this issue, a friend called me up... (loosely quoted) "What's up with the fxp driver? I just setup a box, and it keeps dropping off the net. I have to ifconfig down / ifconfig up it to bring it back to life." I sent him a similar patch to try, but unfortunately the problem stopped repeating itself. :( I'll probably go ahead and make this change to other network drivers I can test soon. Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message