From owner-svn-src-all@FreeBSD.ORG Mon Apr 2 21:49:45 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4FCFA106566B; Mon, 2 Apr 2012 21:49:45 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [70.36.220.4]) by mx1.freebsd.org (Postfix) with ESMTP id 1BFCD8FC08; Mon, 2 Apr 2012 21:49:44 +0000 (UTC) Received: from sa-nc-ipg-172-23-0-161.static.jnpr.net (natint3.juniper.net [66.129.224.36]) (authenticated bits=0) by mail.xcllnt.net (8.14.5/8.14.5) with ESMTP id q32LncjA067379 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 2 Apr 2012 14:49:44 -0700 (PDT) (envelope-from marcel@xcllnt.net) Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=us-ascii From: Marcel Moolenaar In-Reply-To: <20120329181125.GB2358@deviant.kiev.zoral.com.ua> Date: Mon, 2 Apr 2012 14:49:31 -0700 Content-Transfer-Encoding: 7bit Message-Id: <8F9D3269-F501-4F91-B9D8-334DE25E5314@xcllnt.net> References: <201203291750.q2THo1Pu003875@svn.freebsd.org> <20120329181125.GB2358@deviant.kiev.zoral.com.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1257) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, ia64@freebsd.org Subject: Re: svn commit: r233674 - head/libexec/rtld-elf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2012 21:49:45 -0000 On Mar 29, 2012, at 11:11 AM, Konstantin Belousov wrote: > While this band-aid fixes the build, the change is obviously bad. > The reason to have this #ifdef is that ia64 is the only architecture > that declares __tls_get_addr() as > > void *__tls_get_addr(unsigned long module, unsigned long offset); It should actually be: void *__tls_get_addr(size_t module, size_t offset) But size_t equals unsigned long, so the effect is the same. The prototype if __tls_get_addr() is defined in the PSABI document for Itanium. Intel document 245370-003. FYI, -- Marcel Moolenaar marcel@xcllnt.net