From owner-p4-projects@FreeBSD.ORG  Tue Sep 30 08:35:53 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C6ADB16A4C0; Tue, 30 Sep 2003 08:35:52 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 98E4116A4B3; Tue, 30 Sep 2003 08:35:52 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7867643FE1; Tue, 30 Sep 2003 08:35:49 -0700 (PDT)
	(envelope-from arr@watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9p2/8.12.9) with ESMTP id h8UFZF7R005194;
	Tue, 30 Sep 2003 11:35:15 -0400 (EDT)
	(envelope-from arr@watson.org)
Received: from localhost (arr@localhost)h8UFZFDV005191;
	Tue, 30 Sep 2003 11:35:15 -0400 (EDT)	(envelope-from arr@watson.org)
X-Authentication-Warning: fledge.watson.org: arr owned process doing -bs
Date: Tue, 30 Sep 2003 11:35:15 -0400 (EDT)
From: "Andrew R. Reiter" <arr@watson.org>
To: Andrew Reisse <areisse@freebsd.org>
In-Reply-To: <200309301532.h8UFW81Z092302@repoman.freebsd.org>
Message-ID: <20030930113435.H4476@fledge.watson.org>
References: <200309301532.h8UFW81Z092302@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 38889 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Sep 2003 15:35:53 -0000

On Tue, 30 Sep 2003, Andrew Reisse wrote:

:http://perforce.freebsd.org/chv.cgi?CH=38889
:
:Change 38889 by areisse@areisse_tislabs on 2003/09/30 08:32:04
:
:	properly initialize sidtab structures
:	don't divide by zero when empty policy files are loaded
:
:Affected files ...
:
:.. //depot/projects/trustedbsd/sebsd/sys/security/sebsd/ss/fileutils.c#5 edit
:.. //depot/projects/trustedbsd/sebsd/sys/security/sebsd/ss/sidtab.c#7 edit
:
:Differences ...
:
:==== //depot/projects/trustedbsd/sebsd/sys/security/sebsd/ss/fileutils.c#5 (text+ko) ====
:
:@@ -107,6 +107,9 @@
: size_t
: fread(void *ptr, size_t size, size_t nmemb, FILE *fp)
: {
:+	if (size == 0)
:+		return 0;
:+
: 	struct thread *td = curthread;

Won't this generate a parse error?

:
: 	fp->FILE_uio.uio_iov->iov_base = ptr;
:
:==== //depot/projects/trustedbsd/sebsd/sys/security/sebsd/ss/sidtab.c#7 (text+ko) ====
:
:@@ -42,6 +42,7 @@
: 	s->nel = 0;
: 	s->next_sid = 1;
: 	s->shutdown = 0;
:+	memset (&s->lock, 0, sizeof (struct mtx));
: 	INIT_SIDTAB_LOCK(s);
: 	return 0;
: }
:

--
Andrew R. Reiter
arr@watson.org
arr@FreeBSD.org