Date: Fri, 25 Apr 2008 17:12:12 +0300 From: Andriy Gapon <avg@icyb.net.ua> To: Kostik Belousov <kostikbel@gmail.com> Cc: freebsd-hackers@freebsd.org Subject: Re: devctl (alike?) for devfs Message-ID: <4811E6BC.4060306@icyb.net.ua> In-Reply-To: <20080425095009.GD18958@deviant.kiev.zoral.com.ua> References: <480E4269.2090604@icyb.net.ua> <480FBAB9.1000904@icyb.net.ua> <48103F36.6060707@icyb.net.ua> <200804240811.26183.jhb@freebsd.org> <4810FD1E.70602@icyb.net.ua> <20080425095009.GD18958@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
on 25/04/2008 12:50 Kostik Belousov said the following:
> Did you run this with WITNESS ?
>
> You put the whole devctl_notify() call under the dev_mtx. This includes
> the malloc(), PROC_LOCK() and signalling, and some internal devctl_queue()
> stuff. This is wrong.
Kostik,
I tried this patch only with my working (non-debug) configuration.
I will try with WITNESS.
You think that acquiring all those locks while holding dev_mtx is bad?
I can try to place devctl_notify calls in make_dev_credv, make_dev_alias
and destroy_dev. The problem that I see is that destroy_devl ('l' at the
end) calls itself recursively for child devices, this is all done under
dev_mtx. So I am not sure how to call devctl_notify for those child
devices properly.
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4811E6BC.4060306>