From owner-freebsd-ports Mon Oct 7 9:13:31 2002 Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 101ED37B401; Mon, 7 Oct 2002 09:13:30 -0700 (PDT) Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id 49A3543E75; Mon, 7 Oct 2002 09:13:28 -0700 (PDT) (envelope-from ust@cert.siemens.de) Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.11.6/8.11.6) with ESMTP id g97GDPf01134; Mon, 7 Oct 2002 18:13:26 +0200 (MEST) Received: from mars.cert.siemens.de (ust.mchp.siemens.de [139.23.201.17]) by mail1.siemens.de (8.11.6/8.11.6) with ESMTP id g97GDPQ05470; Mon, 7 Oct 2002 18:13:25 +0200 (MEST) Received: from alaska.cert.siemens.de (alaska.cert.siemens.de [139.23.202.134]) by mars.cert.siemens.de (8.12.6/8.12.6/Siemens CERT [ $Revision: 1.25 ]) with ESMTP id g97GDP34076982; Mon, 7 Oct 2002 18:13:25 +0200 (CEST) (envelope-from ust@alaska.cert.siemens.de) Received: from alaska.cert.siemens.de (alaska.cert.siemens.de [127.0.0.1]) by alaska.cert.siemens.de (8.12.6/8.12.6/alaska [ $Revision: 1.14 ]) with ESMTP id g97GDP9p014005; Mon, 7 Oct 2002 18:13:25 +0200 (CEST) (envelope-from ust@alaska.cert.siemens.de) Received: (from ust@localhost) by alaska.cert.siemens.de (8.12.6/8.12.6/alaska [ $Revision: 1.3 ]) id g97GDPNS068474; Mon, 7 Oct 2002 18:13:25 +0200 (CEST) (envelope-from ust) Date: Mon, 7 Oct 2002 18:13:25 +0200 From: Udo Schweigert To: Kris Kennaway Cc: ports@FreeBSD.ORG, eivind@FreeBSD.ORG Subject: Re: Updated dialog-based config patches Message-ID: <20021007161324.GA96101@alaska.cert.siemens.de> References: <20020930062804.GA50001@xor.obsecurity.org> <20021006202120.GA96047@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20021006202120.GA96047@xor.obsecurity.org> X-Operating-System: FreeBSD 4.7-RC User-Agent: Mutt/1.5.1i Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Sun, Oct 06, 2002 at 13:21:21 -0700, Kris Kennaway wrote: > On Sun, Sep 29, 2002 at 11:28:04PM -0700, Kris Kennaway wrote: > >> There's only one bug I'm aware of, involving reconstructing the list >> of options with saved default values, and passing the reconstructed >> list to dialog (this is the 'sed s, ,_,g' thing that shows up in the >> option descriptions). Probably there's a way to fix this, but I >> couldn't see it today. > > I fixed this just now: the updated version has no further problems I > am aware of. I'm intending to commit this in the next week or two; > speak up now if you have any comments. > > http://people.freebsd.org/~kris/bsd.port.mk-config.patch > This only works if the variable is not used for updating files to be fetched (and maybe other stuff). For example I have this in one of my ports: .if defined(WITH_MUTT_COMPRESSED_FOLDERS) PATCHFILES+= patch-${PATCH_VERSION}.rr.compressed.gz CONFIGURE_ARGS+= --enable-compressed SGML_NEEDED= yes .endif Now I added something like this: OPTIONS= MUTT_COMPRESSED_FOLDERS "Compressed folders support" off Everything then works OK, i.e. dialog is comming up, and the chosen options are recorded in the /var/db/ports/... file. But: the option is not in effect. Only aborting the make with a new "make clean; make" will have the chosen options in effect. I think this is because the /var/db/ports file is then read on startup whereas options chosen in dialog do not make their way to "make". Do you think there's a possible solution for that? Or do I miss something? Best regards -- Udo Schweigert, Siemens AG | Voice : +49 89 636 42170 CT IC CERT, Siemens CERT | Fax : +49 89 636 41166 D-81730 Muenchen / Germany | email : udo.schweigert@siemens.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message