From owner-freebsd-alpha  Thu Jun  7 14:36: 4 2001
Delivered-To: freebsd-alpha@freebsd.org
Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9A50637B405; Thu,  7 Jun 2001 14:36:01 -0700 (PDT)
	(envelope-from gallatin@cs.duke.edu)
Received: from grasshopper.cs.duke.edu (grasshopper.cs.duke.edu [152.3.145.30])
	by duke.cs.duke.edu (8.9.3/8.9.3) with ESMTP id RAA26373;
	Thu, 7 Jun 2001 17:35:43 -0400 (EDT)
Received: (from gallatin@localhost)
	by grasshopper.cs.duke.edu (8.11.3/8.9.1) id f57LZDV54952;
	Thu, 7 Jun 2001 17:35:13 -0400 (EDT)
	(envelope-from gallatin@cs.duke.edu)
From: Andrew Gallatin <gallatin@cs.duke.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15135.62352.926539.609146@grasshopper.cs.duke.edu>
Date: Thu, 7 Jun 2001 17:35:12 -0400 (EDT)
To: John Baldwin <jhb@FreeBSD.ORG>
Cc: mjacob@feral.com, dfr@nlsystems.com, freebsd-alpha@FreeBSD.ORG
Subject: RE: CFR: db_trace.c from NetBSD
In-Reply-To: <XFMail.010607142439.jhb@FreeBSD.org>
References: <15135.58046.974661.129491@grasshopper.cs.duke.edu>
	<XFMail.010607142439.jhb@FreeBSD.org>
X-Mailer: VM 6.75 under 21.1 (patch 12) "Channel Islands" XEmacs Lucid
Sender: owner-freebsd-alpha@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-alpha.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-alpha>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-alpha>
X-Loop: FreeBSD.org


John Baldwin writes:
 > 
 > On 07-Jun-01 Andrew Gallatin wrote:
 > > 
 > > I'd like to update our db_trace.c to use Ross Harvey's clever
 > > NetBSD traceback methods.
 > > 
 > > The advantages are that we get a _lot_ more info.
 > 
 > Yes please.  The only comments I would make is that I would not remove the
 > check that bounds the count at 65535 for the default case (so that if you hit a
 > loop it will terminate at 65535 frames not 2 billion frames).  Once this is

Whoops, that was inadvertant.  Thanks for pointing that out.

 > committed I will probably change the way the have_addr branch works to be
 > identical to that on the x86 (just trace pid, not trace tpid).  This looks
 > great.  Thanks!

Thank Ross Harvey.

I've updated the patch.  I'll wait for more comments before comitting
it (probably tomorrow am).

Drew

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-alpha" in the body of the message