Date: Mon, 19 Feb 2001 21:33:47 -0500 From: Greg Lehey <grog@lemis.com> To: Matt Dillon <dillon@earth.backplane.com> Cc: Darren Reed <darrenr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet fil.c ip_auth.c ip_auth.h ip_compat.h ip_fil.c ip_fil.h ip_frag.c ip_frag.h ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c ip_state.c ip_state.h ipl.h mlfk_ipl.c Message-ID: <20010219213347.D21307@sydney.worldwide.lemis.com> In-Reply-To: <200102190119.f1J1J8P32906@earth.backplane.com>; from dillon@earth.backplane.com on Sun, Feb 18, 2001 at 05:19:08PM -0800 References: <200102172042.f1HKg9A20215@freefall.freebsd.org> <200102190119.f1J1J8P32906@earth.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, 18 February 2001 at 17:19:08 -0800, Matt Dillon wrote: >> darrenr 2001/02/17 12:42:09 PST >> >> Modified files: (Branch: RELENG_4) >> sys/netinet fil.c ip_auth.c ip_auth.h ip_compat.h >> ip_fil.c ip_fil.h ip_frag.c ip_frag.h >> ip_ftp_pxy.c ip_log.c ip_nat.c ip_nat.h >> ip_proxy.h ip_raudio_pxy.c ip_rcmd_pxy.c >> ip_state.c ip_state.h ipl.h mlfk_ipl.c >> Log: >> merge changes from 3.4.8 to 3.4.16 >> >> Revision Changes Path >> 1.10.2.6 +146 -40 src/sys/netinet/fil.c >> 1.14.2.5 +2 -2 src/sys/netinet/ip_auth.c >> 1.8.2.2 +1 -3 src/sys/netinet/ip_auth.h >> 1.8.2.2 +43 -17 src/sys/netinet/ip_compat.h >> 1.14.2.4 +33 -10 src/sys/netinet/ip_fil.c >> 1.13.2.3 +4 -1 src/sys/netinet/ip_fil.h >> 1.10.2.3 +5 -3 src/sys/netinet/ip_frag.c >> 1.7.2.2 +3 -2 src/sys/netinet/ip_frag.h >> 1.11.2.3 +39 -19 src/sys/netinet/ip_ftp_pxy.c >> 1.13.2.3 +1 -3 src/sys/netinet/ip_log.c >> 1.12.2.3 +518 -112 src/sys/netinet/ip_nat.c >> 1.8.2.3 +15 -7 src/sys/netinet/ip_nat.h >> 1.7.2.2 +2 -1 src/sys/netinet/ip_proxy.h >> 1.4.2.2 +3 -2 src/sys/netinet/ip_raudio_pxy.c >> 1.4.2.3 +4 -3 src/sys/netinet/ip_rcmd_pxy.c >> 1.13.2.5 +334 -112 src/sys/netinet/ip_state.c >> 1.7.2.3 +2 -1 src/sys/netinet/ip_state.h >> 1.8.2.3 +2 -2 src/sys/netinet/ipl.h >> 1.4.2.2 +17 -1 src/sys/netinet/mlfk_ipl.c > > What in god's name is this? Catching up with -STABLE. > This one MFC appears to cover commits made to current going all > the way back to October 2000, all in one go. Darren, did you > actually test this stuff in aggregate under -stable > significantly before MFCing it? Yes, he did. I complained a while back that he had been committing fixes to -STABLE and not MFCing them after an appropriate time. Now he's done it, and I, for one, am glad about it. > Also, these changes should be MFC'd piecemeal, not all at once, > and the commit message is completely opaque. There appear to be > all sorts of things mixed in here... nat changes, ipv6 changes, > base ip and tcp protocol changes, etc. Yes, I commented on this as well. But I'd rather have the fixes with an inappropriate commit message than not have them. -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010219213347.D21307>