From owner-freebsd-acpi@FreeBSD.ORG Thu Oct 7 16:46:39 2010 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E75881065670 for ; Thu, 7 Oct 2010 16:46:39 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 42C488FC0C for ; Thu, 7 Oct 2010 16:46:38 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA17487 for ; Thu, 07 Oct 2010 19:46:37 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4CADF96D.8040908@freebsd.org> Date: Thu, 07 Oct 2010 19:46:37 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.9) Gecko/20100920 Lightning/1.0b2 Thunderbird/3.1.4 MIME-Version: 1.0 To: freebsd-acpi@freebsd.org X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: acpi_ec: request for review and testing X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2010 16:46:40 -0000 Here's a patch for acpi_ec that is developed in cooperation with David Naylor who also did all the testing: http://people.freebsd.org/~avg/acpi_ec.2.patch The patch quite aggressively changes a few things and tries to make logic more robust with respect to EC behavior. I ask everybody, who is able to help, to test the patch, please. I am interested in all kinds of reports. If your EC "misbehaves", then there is a chance that the patch will fix that. If your EC works fine, then make sure that I don't break it with the patch. Short description of the changes: - attempt to retry some commands for which it is possible (read, query) - always make a short sleep before checking EC status in polled mode - periodically poll EC status in interrupt mode - change logic for detecting broken interrupt delivery and falling back to polled mode - check that EC is ready for input before starting a new command, wait if necessary Big thanks in advance. -- Andriy Gapon