From owner-freebsd-arch Sat Jul 8 8:17:34 2000 Delivered-To: freebsd-arch@freebsd.org Received: from mout1.freenet.de (mout1.freenet.de [194.97.50.132]) by hub.freebsd.org (Postfix) with ESMTP id E8A3B37B60B; Sat, 8 Jul 2000 08:17:31 -0700 (PDT) (envelope-from se@freebsd.org) Received: from [194.97.50.138] (helo=mx0.freenet.de) by mout1.freenet.de with esmtp (Exim 3.15 #1) id 13AwME-0001Ky-00; Sat, 08 Jul 2000 17:17:30 +0200 Received: from a6a05.pppool.de ([213.6.106.5] helo=StefanEsser.FreeBSD.org) by mx0.freenet.de with esmtp (Exim 3.15 #1) id 13AwMD-00050s-00; Sat, 08 Jul 2000 17:17:30 +0200 Received: by StefanEsser.FreeBSD.org (Postfix, from userid 200) id 539CED36; Sat, 8 Jul 2000 14:51:02 +0200 (CEST) Date: Sat, 8 Jul 2000 14:51:01 +0200 From: Stefan Esser To: clefevre@citeweb.net Cc: freebsd-arch@FreeBSD.ORG, Stefan Esser Subject: Re: [Patch] make test,expr,printf support 64bit integers Message-ID: <20000708145101.A3242@StefanEsser.FreeBSD.org> Reply-To: Stefan Esser References: <20000703184219.A7587@StefanEsser.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: ; from clefevre@no-spam.citeweb.net on Thu, Jul 06, 2000 at 02:03:48AM +0200 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 2000-07-06 02:03 +0200, Cyrille Lefevre wrote: > > -static int getlong __P((long *)); > > +static int getlong __P((quad_t *)); > ^^^^^^^ getquad > > if (getlong(&val)) > ^^^^^^^ getquad > IMHO, be consistent w/ naming convention (getlong -> getquad). Thanks for your comment! Yes, you are of course right. I remember to have considered changing the name to match the type, but for reasons I can't remember decided against this. (Probably because I wanted to restrict the patch to just the functional changes.) I'll change the ifunction name as you propose. If there are no other comments or requests for further changes, I'll commit the 64Bit extension on Sunday or Monday. Regards, STefan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message