From owner-freebsd-stable@FreeBSD.ORG  Tue Apr 22 18:36:30 2008
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 50A99106568B
	for <freebsd-stable@freebsd.org>; Tue, 22 Apr 2008 18:36:30 +0000 (UTC)
	(envelope-from zbeeble@gmail.com)
Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.191])
	by mx1.freebsd.org (Postfix) with ESMTP id C39628FC16
	for <freebsd-stable@freebsd.org>; Tue, 22 Apr 2008 18:36:29 +0000 (UTC)
	(envelope-from zbeeble@gmail.com)
Received: by ti-out-0910.google.com with SMTP id j2so845343tid.3
	for <freebsd-stable@freebsd.org>; Tue, 22 Apr 2008 11:36:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
	bh=PouJflnsLg9G7T7uQBLGucw1o4HAGAbRLnNy0znEPT8=;
	b=En5Is6iDBAqSDaKcw+a+yEnJLQ8prnPaJRBXfJlUR01sCj163789rDXbZ9VfWm6jyDES6BXniYDfM4sEwUWCZqR+ef8aSju6B+qEs0ug0gOejGIDM/UaIOGP/VDGfy5tn0+FoQoH8FXsrQiR8Pt1I5IZuFdn3baonuwWYsqsFBs=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
	b=LHGxuqoxNjim/uDIPkjt1OYj6X9GhltbBYRmDVNTZBnjUJ/CuWmUimLUkU0bXKQiYloum96RMCdRBTAkmm+jcFVabU769kWG7fhXXL3DQT4Q0zHCSx3L2yB0DaO3H0Lr6C8lEobCvHfQr2eNcXvx2Z+E9tnT6XcqO3p/RdXysCU=
Received: by 10.150.58.5 with SMTP id g5mr659727yba.89.1208889386733;
	Tue, 22 Apr 2008 11:36:26 -0700 (PDT)
Received: by 10.150.156.14 with HTTP; Tue, 22 Apr 2008 11:36:26 -0700 (PDT)
Message-ID: <5f67a8c40804221136s2c1893c0tdd00c627ab813c59@mail.gmail.com>
Date: Tue, 22 Apr 2008 14:36:26 -0400
From: "Zaphod Beeblebrox" <zbeeble@gmail.com>
To: "Andrew Snow" <andrew@modulus.org>
In-Reply-To: <480D7F58.1080203@modulus.org>
MIME-Version: 1.0
References: <E1JnuQf-000LaE-5n@dilbert.ticketswitch.com>
	<480D7F58.1080203@modulus.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-stable@freebsd.org, Pete French <petefrench@ticketswitch.com>
Subject: Re: Dreadful gmirror performance, though each half works fine
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Apr 2008 18:36:30 -0000

On Tue, Apr 22, 2008 at 2:02 AM, Andrew Snow <andrew@modulus.org> wrote:

> Pete French wrote:
>
> > I did some benchmarking, and "load" gives me a bit better performance
> > than
> > "round-robin" so I've elected to use that. Haven't tried "prefer" as
> > syncing all the drives backwards and forwards to get the preferences set
> > seems a bit too much like hard work!
> >
>
> I use this patch for sbin/geom/class/mirror/geom_mirror.c
>
> Change:
>  md.md_priority = i - 1;
> To:
>  md.md_priority = i - 1 + 100;


I hate to ask for the "right"  solution, but shouldn't we be patching the
gmirror userland to accept a priority argument to label and make the kernel
part listen to that?  This patch does make sense --- but it doesn't go far
enough.

Also, it seems sensible that you should be able to modify the priority
values of a running disk.