Date: Wed, 8 Sep 2004 14:34:35 -0700 From: Sean Chittenden <chitt@speakeasy.net> To: standards@freebsd.org Subject: Trivial cleanup for lib/libutil/libutil.h... Message-ID: <200409081434.35952.chitt@speakeasy.net>
next in thread | raw e-mail | index | archive | help
--Boundary-00=_rr3PBiq01cMFQZ6 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Howdy. I was looking at fparseln(3)'s declaration in include/libutil.h and noticed that it's wrapped in an #ifdef _STDIO_H_. Is there any reason to have FPARSELN_* not wrapped in the same #define? If not, the attatched wraps the #define's so that they only apply when fparseln(3) is visible. Are there any objections to me committing this change? -sc -- Sean Chittenden seanc@FreeBSD.org --Boundary-00=_rr3PBiq01cMFQZ6 Content-Type: text/x-diff; charset="us-ascii"; name="patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patch" Index: lib/libutil/libutil.h =================================================================== RCS file: /home/ncvs/src/lib/libutil/libutil.h,v retrieving revision 1.40 diff -u -r1.40 libutil.h --- lib/libutil/libutil.h 24 May 2004 22:19:27 -0000 1.40 +++ lib/libutil/libutil.h 8 Sep 2004 20:41:10 -0000 @@ -121,11 +121,13 @@ #define HOSTNAME_INVALIDNAME (3) /* fparseln(3) */ +#ifdef _STDIO_H_ #define FPARSELN_UNESCESC 0x01 #define FPARSELN_UNESCCONT 0x02 #define FPARSELN_UNESCCOMM 0x04 #define FPARSELN_UNESCREST 0x08 #define FPARSELN_UNESCALL 0x0f +#endif /* pw_scan() */ #define PWSCAN_MASTER 0x01 --Boundary-00=_rr3PBiq01cMFQZ6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409081434.35952.chitt>