From owner-cvs-src@FreeBSD.ORG Tue Apr 6 11:42:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2AF2F16A4CF; Tue, 6 Apr 2004 11:42:02 -0700 (PDT) Received: from mailbox.univie.ac.at (mailbox.univie.ac.at [131.130.1.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3417943D5A; Tue, 6 Apr 2004 11:42:01 -0700 (PDT) (envelope-from le@FreeBSD.org) Received: from wireless (adslle.cc.univie.ac.at [131.130.102.11]) i36IexLc1270840; Tue, 6 Apr 2004 20:41:01 +0200 Date: Tue, 6 Apr 2004 20:41:01 +0200 (CEST) From: Lukas Ertl To: Nate Lawson In-Reply-To: <20040406113129.T28582@root.org> Message-ID: <20040406204024.X631@korben> References: <200404031740.i33HeKH6016345@repoman.freebsd.org> <20040403184246.GA613@darkness.comp.waw.pl> <20040406194620.P631@korben> <20040406113129.T28582@root.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-DCC-ZID-Univie-Metrics: mailbox 4246; Body=0 Fuz1=0 Fuz2=0 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Pawel Jakub Dawidek cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/growfs Makefile debug.c growfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 18:42:02 -0000 On Tue, 6 Apr 2004, Nate Lawson wrote: > On Tue, 6 Apr 2004, Lukas Ertl wrote: > > On Sat, 3 Apr 2004, Pawel Jakub Dawidek wrote: > > > > > On Sat, Apr 03, 2004 at 09:40:20AM -0800, Lukas Ertl wrote: > > > +> > > > +> Modified files: > > > +> sbin/growfs Makefile debug.c growfs.c > > > +> Log: > > > +> Make growfs WARNS=6 clean. > > > > > > AFAIK growfs(8) doesn't work with UFS2, so maybe while you are here... :) > > > > It works on UFS2, but not very well. Yes, I'll have a look, but maybe > > I'll make a big style sweep first, so I can actually read what's going on > > there. :-) > > It does work but there are problems. First thing that should be done is > factor out the superblock update code and have growfs bring it up to > canonical (latest) form before processing the fs. Also, there are minor > things like it removing flags like ACLs from the superblock. Do you still have the patches you talked about floating around? cheers, le -- Lukas Ertl http://mailbox.univie.ac.at/~le/ le@FreeBSD.org http://people.freebsd.org/~le/